ISSUE-151 - Fix a bug where a report wasn't written if any warning #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderejd
reviewed
Dec 6, 2020
cargo-geiger/src/scan/default.rs
Outdated
| @@ -115,7 +115,7 @@ fn scan_to_report( | |||
| root_package_id: PackageId, | |||
| scan_parameters: &ScanParameters, | |||
| workspace: &Workspace, | |||
| ) -> Result<Vec<String>, CliError> { | |||
| ) -> Result<(Vec<String>, u64), CliError> { | |||
There was a problem hiding this comment.
A doc comment describing what this (Vec<String>, u64) represents would be nice, alternatively a dedicated struct with a descriptive name and descriptive member names.
There was a problem hiding this comment.
Sounds good! I've created the ScanResult struct to be returned as the result, if that looks OK?
jmcconnell26
force-pushed
the
ISSUE-151-FixNotWritingReportIfWarningFound
branch
from
9a14548
to
abc9bfa
Compare
was found: * When updating the scanning functions to return results as a vec of strings, a bug was introduced where the report would only be written if no warnings were returned * Creating `ScanResult` struct to hold output from scan functions Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
jmcconnell26
force-pushed
the
ISSUE-151-FixNotWritingReportIfWarningFound
branch
from
abc9bfa
to
2e51b9a
Compare
jmcconnell26
pushed a commit
to jmcconnell26/cargo-geiger
that referenced
this pull request
Dec 10, 2020
…itingReportIfWarningFound ISSUE-151 - Fix a bug where a report wasn't written if any warning Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was found:
strings, a bug was introduced where the report would only be written
if no warnings were returned
Signed-off-by: joshmc josh-mcc@tiscali.co.uk