Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crate version & clippy lints to compile with Rust version 1.76.0 #529

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

justahero
Copy link

@justahero justahero commented Dec 4, 2024

This reverts the version of cargo_metadata to 0.15.4 to compile the project again (worked locally). It undos PR #483. Using a recent version of cargo_metadata results in compile errors due to conflicts with types from the krates crate.

  • remove #![deny(warnings]) from source, activate CI job to run clippy instead with -D warnings
  • fix all clippy warnings in the code to conform to Rust 1.76.0
  • update all GH checkout actions to version 4
  • set Rust version 1.76.0 on CI instead of stable to avoid any issues with new clippy lints

P.S. the logs of the Github Actions in PR #528 is not available anymore, therefore opening this PR.

justahero and others added 5 commits December 4, 2024 14:23
This reverts the version of `cargo_metadata` to `0.15.4`, that undos PR
geiger-rs#483.

* update all GH checkout actions to version 4
Updates `time` dependency to latest.
See rust-lang/rust#127343 for more info.
* activate clippy CI job instead that treats all warnings as errors.
This is to ensure that an update of the Rust language does not cause CI
to fail, due to new lints. The Rust version available for the last
commit on `master` is 1.76.0, therefore CI uses that.

With this change an update of the Rust version does not break things.
@justahero justahero changed the title Revert version update of cargo_metadata Fix crate version & clippy lints to compile with Rust version 1.76.0 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants