Table-ized output formatting #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since better output formatting was on the roadmap, i tried making the different kinds of unsafe counters more visible by default.
The idea is to have a
(Functions Expressions Impls Traits Methods)table on the left, and the same radioactive symbol + tree structure + dependency name on the right.Of couse, the table solution is not the most elegant, and should be factored out along with the tree generation. Similarly, the compact_output flag now passed thru multiple functions should probably be part of some output formatting control struct.
The old output format is kept under the '--compact' switch.
Let me know what you think and if anything should be reworked before it's pullable.
