VorbisComment Recommendation and Chapter Support #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks I patched this on the master branch of cozy and it works flawlessly. Thanks a lot and hopefully it would be merged soon. |
|
I have no idea what issue Github has with the CI. I tried using the "Explain error" Copilot button, but it hallucinated garbage about |
rdbende
approved these changes
Feb 11, 2025
|
Found the issue: flatpak/flatpak-github-actions#214 |
|
Thanks, @rgarber11! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, while cozy supports .opus files, it doesn't follow the xiph.org comment recommendations for tags or parse chapters. This pull request parses the author and reader per the above document, and also gets chapters if they conform to the ChapterExtension.