Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Seq and List decoding #138

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Support Seq and List decoding #138

merged 1 commit into from
Sep 27, 2023

Conversation

geirolz
Copy link
Owner

@geirolz geirolz commented Sep 27, 2023

Fix #137 in order to provide a proper Decoder[Seq[T]] and Decoder[List[T]] implementation.

Moreover flat groups in order to support Down operator in nested cases

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (843a291) 65.11% compared to head (06bad04) 65.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   65.11%   65.24%   +0.12%     
==========================================
  Files          59       59              
  Lines        2680     2690      +10     
  Branches      143      303     +160     
==========================================
+ Hits         1745     1755      +10     
  Misses        935      935              
Files Coverage Δ
core/src/main/scala/cats/xml/xmlNode.scala 69.04% <100.00%> (+1.23%) ⬆️
...src/main/scala/cats/xml/std/nodeSeqConverter.scala 71.42% <66.66%> (ø)
core/src/main/scala/cats/xml/NodeContent.scala 74.41% <62.50%> (-10.59%) ⬇️
core/src/main/scala/cats/xml/codec/Decoder.scala 76.63% <45.45%> (+1.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy-scalameta-pro (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scalastyle (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@geirolz geirolz merged commit 5d1d2d5 into main Sep 27, 2023
19 of 20 checks passed
@geirolz geirolz deleted the supports-collections branch September 27, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for decoding list of nodes
1 participant