Fix long numbers problem #98
Conversation
geirolz
force-pushed
the
fix_long_numbers_problem
branch
from
5b9a56d to
8331b94
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Scalastyle (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
| case bd if bd.isValidLong => ofLong(bd.toLongExact) | ||
| case db if db.isDecimalFloat => ofFloat(db.floatValue) | ||
| case db if db.isDecimalDouble => ofDouble(db.doubleValue) | ||
| case bd => ofBigDecimal(bd) | ||
| case bd => |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Prohibit case statement pattern match from being lowercase.
| case db if db.isValidByte => ofLong(db.toByteExact.toLong) | ||
| case db if db.isValidShort => ofLong(db.toShortExact.toLong) | ||
| case db if db.isValidInt => ofLong(db.toIntExact.toLong) | ||
| case db if db.isValidByte => ofByte(db.toByteExact) |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Prohibits same expression on cases inside the same scope
| testFromDataString[BigDecimal] | ||
| testFromDataString[VeryLongNumericString] | ||
|
|
||
| private def testFromNumberString[T: Arbitrary](shouldFail: Boolean = false)(implicit |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Values should have minimum scope to avoid misuses.
| property(s"Xml.fromNumberString works with ${c.runtimeClass.getSimpleName}") { | ||
| forAll { (value: T) => | ||
| assertEquals( | ||
| Xml.fromNumberString(value.toString).get.toBigDecimal, |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Calling get should be avoided on Option and Either.
| number.toBigDecimal, | ||
| Some(BigDecimal(value.toString)) | ||
| ) | ||
| case other => |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Prohibit case statement pattern match from being lowercase.
| } | ||
| } | ||
|
|
||
| private def testFromDataString[T: Arbitrary](implicit |
Check notice
Code scanning / Codacy-scalameta-pro (reported by Codacy)
Values should have minimum scope to avoid misuses.
No description provided.