Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display flex for Grid component #284

Closed
fabricionaweb opened this issue Jun 23, 2020 · 3 comments
Closed

Display flex for Grid component #284

fabricionaweb opened this issue Jun 23, 2020 · 3 comments
Assignees
@unix
Labels
type: bug Something isn't working

Comments

@fabricionaweb
Copy link

With the changes on #280 the default display for Grid component (in my case it was block) now changed to flex but I need at least flex-wrap (or the previous default display block was fine)

I have some ideas:

  • Create a prop to wrap into Grid component (like Grid.container has)
  • Dont change the display prop in Grid component, maybe just remove it (instead of set to flex)
  • Ability to pass styles through Grid component

What do you think guys?
@unix
Copy link
Member

unix commented Jun 23, 2020

Agreed with you.

  1. The extra style display: flex is an error, I'll remove it, back to previous version.
  2. It's an error that style can't be used on Grid, and I'll fix it.

@unix unix added the type: bug Something isn't working label Jun 23, 2020
@unix unix self-assigned this Jun 23, 2020
@unix unix mentioned this issue Jun 23, 2020
Merged
2 tasks
@unix
Copy link
Member

unix commented Jun 23, 2020

@fabricionaweb
v1.7.2 released, it should solved this issue.

@fabricionaweb
Copy link
Author

So quickly, thanks for you job man, awesome :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unix unix

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabricionaweb @unix