Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with react 17 #519

Closed
Gounlaf opened this issue Apr 20, 2021 · 0 comments
Closed

Incompatibility with react 17 #519

Gounlaf opened this issue Apr 20, 2021 · 0 comments

Comments

@Gounlaf
Copy link
Contributor

Gounlaf commented Apr 20, 2021

Bug report 🐞

Version & Environment

  • Version of browser: doesn't matter
  • Version of geist-ui/react: latest when reporting this issue: 2.1.5

Expected Behaviour

Usage of @geist-ui/reac should work with npm & yarn (according to the documentation)

Actual results (or Errors)

Someone reported in discussion #512 having an issue with npm, but resolved with yarn.
Looking at dependency tree, using styled-jsx@3.3.0 (strictly 3.3.0 ; not available for upgrade) require react@16 ; support for react@17 added in styled-jsx@3.3.1.

I guess yarn and npm resolve dependencies differently.

Edit: I can blindly update the dependency and make a PR, but I have no idea of the consequences...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants