Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update styled-jsx to ^3.3.1 #520

Merged
merged 3 commits into from
Apr 22, 2021
Merged

chore(deps): update styled-jsx to ^3.3.1 #520

merged 3 commits into from
Apr 22, 2021

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Apr 20, 2021

Fix for #519

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Update styled-jsx to ^3.3.1 to allow compatibility with react@^17

@unix
Copy link
Member

unix commented Apr 21, 2021

styled-jsx#695 This issue has not been fixed and will not be packaged even if we upgrade.
It is not possible to upgrade this dependency yet, so perhaps we should look for another solution to replace styled-jsx.

@unix
Copy link
Member

unix commented Apr 21, 2021

Maybe the compatibility code in 695 is the way to go. (add a hack to the runtime)

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Apr 21, 2021

Hi @unix,

Well, at least could it be frozen to styled-jsx@3.3.1 instead of styled-jsx@^3.3.1 ?

@unix
Copy link
Member

unix commented Apr 21, 2021

Well, at least could it be frozen to styled-jsx@3.3.1 instead of styled-jsx@^3.3.1 ?

The current version we have released is frozen in version 3.3.0. I have tried to upgrade to 3.3.1, but the esm package is buggy and I still need to test and debug the esm bundle. 😢
It's really troublesome here, I will maintain this PR. (most of the work is needed to test the availability of the esm bundle)

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Apr 21, 2021

I have tried to upgrade to 3.3.1, but the esm package is buggy and I still need to test and debug the esm bundle. cry
It's really troublesome here, I will maintain this PR. (most of the work is needed to test the availability of the esm bundle)

Okay =/.
I will stick to styled-js@3.3.0 / react@16 until vercel/styled-jsx#695 is fixed.

Can't help you much around the esm bundle issues, my knowledge in js / ts / es modules are really limited

update styled-jsx to ^3.3.1 to allow compatiblity with react@^17
@unix unix self-assigned this Apr 22, 2021
@unix unix added type: bug Something isn't working type: dependencies Pull requests that update a dependency file type: chore labels Apr 22, 2021
@unix
Copy link
Member

unix commented Apr 22, 2021

I tried to fix this issue with dirty code and so far it seems to be compatible with React 17, I did some local testing of the module but can't guarantee the coverage of the module.
I have moved the target to the rc branch and plan to release a few canary versions as trial versions, and if there are no problems, I will point stable to the latest version later.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #520 (62a6bbc) into rc (17cb6dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               rc     #520   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         183      183           
  Lines        2454     2455    +1     
  Branches      606      607    +1     
=======================================
+ Hits         2452     2453    +1     
  Misses          2        2           
Impacted Files Coverage Δ
components/grid/grid-container.tsx 100.00% <ø> (ø)
components/grid/grid.tsx 100.00% <ø> (ø)
components/modal/modal-action.tsx 100.00% <ø> (ø)
components/css-baseline/css-baseline.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17cb6dd...62a6bbc. Read the comment docs.

@unix
Copy link
Member

unix commented Apr 22, 2021

@ofekashery
Recently, Vercel often fails to build because the default cache cannot be removed and each build reverts to an earlier cache configuration, so we have to manually redeploy to clear the cache.
Right now Vercel cannot manually configure the cache... 😿

I think the cache error is caused by migrating from the nowignore file to the vercelignore file.
(Oh, I made a mistake this time... 😩 )

@unix unix merged commit da1532f into geist-org:rc Apr 22, 2021
unix added a commit that referenced this pull request Apr 29, 2021
* chore(deps): update styled-jsx to ^3.3.1

update styled-jsx to ^3.3.1 to allow compatiblity with react@^17

* fix(modules): fix 695-issue to compatible with React 17

* docs: fix module error caused by styled-jsx update

Co-authored-by: unix <unix.bio@gmail.com>
unix added a commit that referenced this pull request May 3, 2021
* chore(deps): update styled-jsx to ^3.3.1

update styled-jsx to ^3.3.1 to allow compatiblity with react@^17

* fix(modules): fix 695-issue to compatible with React 17

* docs: fix module error caused by styled-jsx update

Co-authored-by: unix <unix.bio@gmail.com>
unix added a commit that referenced this pull request Aug 13, 2021
* chore(deps): update styled-jsx to ^3.3.1

update styled-jsx to ^3.3.1 to allow compatiblity with react@^17

* fix(modules): fix 695-issue to compatible with React 17

* docs: fix module error caused by styled-jsx update

Co-authored-by: unix <unix.bio@gmail.com>
unix added a commit that referenced this pull request Aug 13, 2021
* feat(slider): add option to hide slider value (#494)

* feat(slider): hideValue prop added

* test(slider): test added for hideValue prop

docs(slider): add hideValue prop

docs(slider): add hideValue prop for cn docs

feat(slider): ensure the dot stays round when no content

test(slider): update snapshots

* feat(loading): apply width & height props (#500)

* feat(loading): apply width & height props

* test(loading): test case added & updating snapshots

* fix(loading): add a string type for size prop

test(loading): update test case & snapshots

* feat(loading): support custom the ratio of spaces

* docs(loading): append size and spaceRatio

test(loading): update snapshots

Co-authored-by: unix <unix.bio@gmail.com>

* chore(deps): update styled-jsx to ^3.3.1 (#520)

* chore(deps): update styled-jsx to ^3.3.1

update styled-jsx to ^3.3.1 to allow compatiblity with react@^17

* fix(modules): fix 695-issue to compatible with React 17

* docs: fix module error caused by styled-jsx update

Co-authored-by: unix <unix.bio@gmail.com>

* chore: release v2.2.0-rc.0

* fix(modal): disable backdrop even if actions missing (#532)

* fix: upgrade to be compatible with React-17's event system (#533)

* feat: useKeyboard hooks (#541)

* feat(keyboard): create keyboard hooks

* feat(usekeyboard): redesign event handler to match keyboard events from browser

\

* test(usekeyboard): add testcase

* docs(usekeyboard): create new hooks document

* chore: release v2.2.0-rc.1

* feat(auto-complete): add forwardRef for input element (#542)

* feat(auto-complete): add forwardRef for input element

* test(auto-complete): add testcase to ensure ref is available

* docs(auto-complete): append props for ref

* chore: release v2.2.0-rc.2

* fix(auto-complete): fix size of loading icon (#546)

* chore: release v2.2.0-rc.3

* fix(auto-complete): hide shadow when no content (#547)

* chore: release v2.2.0-rc.4

* feat: add status prop in checkbox, radio, select, slider and toggle (#530)

* feat: added status prop to set color by states

test: check status success, warning and error

* docs: added playground example and API reference

fix: replaced ´_´ as it's not recommended to use

fix: removed redundant return

refactor: renamed prop from status to type

test: update test with the renamed prop

* docs: update prop references from status to type

fix: status prop not updated to type

fix: missing return

* fix(select): set icons and hover state to follow the theme

* test(slider): update snapshots

* chore: always use relative paths when import types

Co-authored-by: unix <unix.bio@gmail.com>

* feat(auto-complete): add props for popup container (#558)

* feat(auto-complete): add props for popup container

* docs(auto-complete): add attribute for popup container

* chore: release v2.2.0-rc.5

* fix: fix path error under esm

* chore: release v2.2.0-rc.6

* feat(scaleable): add scaleable props to each component (#531)

* feat(scaleable): add scaleable props to each component

* chore(scaleable): update the exported type

* feat: apply scaleable to components

chore: remove with-default

test: improve testcase for scaleable

chore: resolve test warning

ci: upgrade nodejs to latest lts

docs: fix type error in document site

* docs: update documents to be compatible with scaleable

chore: fix build errors

* chore: remove all size-related attributes

docs: improve guide document

* docs: add scaleable documentation

test: update snapshots

chore: remove unused

* feat: add scaleable to grid components

* docs: improve docs

* test: update snapshots

* fix(grid): fix basic component props

* feat: export all types related to components (#562)

* feat: export all types related to components

fix(tooltip): fix the vertical offset of the arrow

* refactor: optimize events of all popup related components

* test: append testcases for popup base component

* test: add testcase for visible events

* test: update snapshots

* fix(bundle): fix modules missing in yarn berry (#563)

* chore: add peer dependencies

* fix(bundle): fix modules missing in yarn berry

* chore: upgrade configs for jest 27

* chore(examples): upgrade next examples for scaleable (#564)

* chore: release v2.2.0-rc.7

* feat(rating): a new component rating indicator (#543)

* chore(deps): bump lodash from 4.17.20 to 4.17.21 (#537)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* (feature) rating state working and islocked working

* (feature) custom emojis for the ratings added

* refactor(rating): migrate component to scaleable

* feat(rating): use inline icon component

test(rating): update testcase

* docs(rating): add document for zh-cn

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: unix <unix.bio@gmail.com>

* refactor(table): redesign interfaces to improve the experience in TypeScript (#569)

* refactor(table): redesign interfaces to improve the experience in TypeScript

* docs: upgrade to new type exports

* style: fix lint warnings

* docs: fix sidebar text-transform (#570)

* docs: improve the copywriting content of the document (#571)

* docs: export individual style types for each component

* docs: improve the copywriting content of the document

* docs: optimize the document site experience on mobile devices

* chore: release v2.2.0-rc.8

* feat(modal): responds to keyboard events when modal is displayed (#574)

* docs: redesign mobile navigation (#576)

* docs: redesign mobile navigation

* docs: fix subheading active color

* fix(avatar): fix margin on first child (#578)

Co-authored-by: witt <unix.bio@gmail.com>

* feat(select): imporve the focus events to export simulated ref (#579)

* feat(select): imporve the focus events to export simulated ref

* test: improve testcase and fix warnings

* docs(select): add label and divider to props docs

* fix: rename hymlType to htmlType (#599)

* feat(drawer): create component (#575)

* feat(drawer): create component

* feat(drawer): refinement of drawer component

* test: update tool chain for jest

* test: simplify events case for jest

* docs(drawer): add playground

* docs(drawer): add api docs

* docs: add home page (#573)

* docs: add home page

* docs(homepage): apply suggestions from code review

* docs(homepage): make cards clickable

Co-authored-by: witt <unix.bio@gmail.com>

* test: update snapshots for scaleable

* chore: update lock file

* chore: upgrade styled-jsx

* test: update snapshots for styled-jsx

Co-authored-by: Deepankar <deep14bhade@gmail.com>
Co-authored-by: Deepankar <statisticsaffinity@gmail.com>
Co-authored-by: Florian Levis <levis.florian@gmail.com>
Co-authored-by: gepd <guillermoepd@hotmail.com>
Co-authored-by: Nils J <nils.jorek@gmx.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ofek Ashery <ofek.ashery@gmail.com>
Co-authored-by: Sanna Jammeh <50969683+sannajammeh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: chore type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants