feat(slider): add option to hide slider value #494

Deep-Codes · 2021-03-30T07:23:19Z

Checklist

Fix linting errors
Tests have been added / updated (or snapshots)

Change information

Adds the Feature of hideValue prop in Slider Component

Closes #491

codecov · 2021-03-30T07:25:39Z

Codecov Report

Merging #494 (b061099) into rc (18d08f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b061099 differs from pull request most recent head ec9c610. Consider uploading reports for the commit ec9c610 to get more accurate results

@@           Coverage Diff           @@
##               rc     #494   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         183      183           
  Lines        2453     2454    +1     
  Branches      604      605    +1     
=======================================
+ Hits         2451     2452    +1     
  Misses          2        2

Impacted Files	Coverage Δ
components/slider/slider.tsx	`98.57% <100.00%> (+0.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d08f8...ec9c610. Read the comment docs.

Deep-Codes · 2021-03-31T04:41:21Z

@ofekashery Should I Update Docs with Example?

unix

👍 I think this is a good feature, no need to add additional examples.
Also, the documentation is here: /pages/en-us/components/slider, can you add the documentation in at least one language?

unix · 2021-03-31T11:54:03Z

components/slider/slider.tsx

@@ -14,6 +14,7 @@ import SliderDot from './slider-dot'
 import SliderMark from './slider-mark'

 interface Props {
+  hideValue?: boolean


The following default values need to be added to the:

hideValue: false,

Alright i would add default props here:

https://github.com/geist-org/react/blob/18d08f8accc70a66cc69140846598665b686f0df/components/slider/slider.tsx#L28

and in docs update the table for hideValue prop

Added a Commit should work

if not let me know more than happy to ammend

Also, have 2 more PRs to work on this Repo 💙

unix · 2021-03-31T13:52:45Z

Thank you very much for your contribution, it will be merged into the feature branch later.

ofekashery

Please add min-width: 1.25rem to the dot style, so it'll be a circle.

unix · 2021-03-31T13:58:46Z

@ofekashery Now it looks like the slider component also needs the size property, the default size looks too big 😿

docs(slider): add hideValue prop docs(slider): add hideValue prop for cn docs feat(slider): ensure the dot stays round when no content test(slider): update snapshots

unix · 2021-03-31T14:00:25Z

Please add min-width: 1.25rem to the dot style, so it'll be a circle.

@ofekashery I've added some changes, so if you think it's okay you can just merge.

ofekashery · 2021-03-31T18:23:48Z

Thank you, @Deep-Codes! 🚀

* feat(slider): hideValue prop added * test(slider): test added for hideValue prop docs(slider): add hideValue prop docs(slider): add hideValue prop for cn docs feat(slider): ensure the dot stays round when no content test(slider): update snapshots

* feat(slider): add option to hide slider value (#494) * feat(slider): hideValue prop added * test(slider): test added for hideValue prop docs(slider): add hideValue prop docs(slider): add hideValue prop for cn docs feat(slider): ensure the dot stays round when no content test(slider): update snapshots * feat(loading): apply width & height props (#500) * feat(loading): apply width & height props * test(loading): test case added & updating snapshots * fix(loading): add a string type for size prop test(loading): update test case & snapshots * feat(loading): support custom the ratio of spaces * docs(loading): append size and spaceRatio test(loading): update snapshots Co-authored-by: unix <unix.bio@gmail.com> * chore(deps): update styled-jsx to ^3.3.1 (#520) * chore(deps): update styled-jsx to ^3.3.1 update styled-jsx to ^3.3.1 to allow compatiblity with react@^17 * fix(modules): fix 695-issue to compatible with React 17 * docs: fix module error caused by styled-jsx update Co-authored-by: unix <unix.bio@gmail.com> * chore: release v2.2.0-rc.0 * fix(modal): disable backdrop even if actions missing (#532) * fix: upgrade to be compatible with React-17's event system (#533) * feat: useKeyboard hooks (#541) * feat(keyboard): create keyboard hooks * feat(usekeyboard): redesign event handler to match keyboard events from browser \ * test(usekeyboard): add testcase * docs(usekeyboard): create new hooks document * chore: release v2.2.0-rc.1 * feat(auto-complete): add forwardRef for input element (#542) * feat(auto-complete): add forwardRef for input element * test(auto-complete): add testcase to ensure ref is available * docs(auto-complete): append props for ref * chore: release v2.2.0-rc.2 * fix(auto-complete): fix size of loading icon (#546) * chore: release v2.2.0-rc.3 * fix(auto-complete): hide shadow when no content (#547) * chore: release v2.2.0-rc.4 * feat: add status prop in checkbox, radio, select, slider and toggle (#530) * feat: added status prop to set color by states test: check status success, warning and error * docs: added playground example and API reference fix: replaced ´_´ as it's not recommended to use fix: removed redundant return refactor: renamed prop from status to type test: update test with the renamed prop * docs: update prop references from status to type fix: status prop not updated to type fix: missing return * fix(select): set icons and hover state to follow the theme * test(slider): update snapshots * chore: always use relative paths when import types Co-authored-by: unix <unix.bio@gmail.com> * feat(auto-complete): add props for popup container (#558) * feat(auto-complete): add props for popup container * docs(auto-complete): add attribute for popup container * chore: release v2.2.0-rc.5 * fix: fix path error under esm * chore: release v2.2.0-rc.6 * feat(scaleable): add scaleable props to each component (#531) * feat(scaleable): add scaleable props to each component * chore(scaleable): update the exported type * feat: apply scaleable to components chore: remove with-default test: improve testcase for scaleable chore: resolve test warning ci: upgrade nodejs to latest lts docs: fix type error in document site * docs: update documents to be compatible with scaleable chore: fix build errors * chore: remove all size-related attributes docs: improve guide document * docs: add scaleable documentation test: update snapshots chore: remove unused * feat: add scaleable to grid components * docs: improve docs * test: update snapshots * fix(grid): fix basic component props * feat: export all types related to components (#562) * feat: export all types related to components fix(tooltip): fix the vertical offset of the arrow * refactor: optimize events of all popup related components * test: append testcases for popup base component * test: add testcase for visible events * test: update snapshots * fix(bundle): fix modules missing in yarn berry (#563) * chore: add peer dependencies * fix(bundle): fix modules missing in yarn berry * chore: upgrade configs for jest 27 * chore(examples): upgrade next examples for scaleable (#564) * chore: release v2.2.0-rc.7 * feat(rating): a new component rating indicator (#543) * chore(deps): bump lodash from 4.17.20 to 4.17.21 (#537) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (feature) rating state working and islocked working * (feature) custom emojis for the ratings added * refactor(rating): migrate component to scaleable * feat(rating): use inline icon component test(rating): update testcase * docs(rating): add document for zh-cn Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: unix <unix.bio@gmail.com> * refactor(table): redesign interfaces to improve the experience in TypeScript (#569) * refactor(table): redesign interfaces to improve the experience in TypeScript * docs: upgrade to new type exports * style: fix lint warnings * docs: fix sidebar text-transform (#570) * docs: improve the copywriting content of the document (#571) * docs: export individual style types for each component * docs: improve the copywriting content of the document * docs: optimize the document site experience on mobile devices * chore: release v2.2.0-rc.8 * feat(modal): responds to keyboard events when modal is displayed (#574) * docs: redesign mobile navigation (#576) * docs: redesign mobile navigation * docs: fix subheading active color * fix(avatar): fix margin on first child (#578) Co-authored-by: witt <unix.bio@gmail.com> * feat(select): imporve the focus events to export simulated ref (#579) * feat(select): imporve the focus events to export simulated ref * test: improve testcase and fix warnings * docs(select): add label and divider to props docs * fix: rename hymlType to htmlType (#599) * feat(drawer): create component (#575) * feat(drawer): create component * feat(drawer): refinement of drawer component * test: update tool chain for jest * test: simplify events case for jest * docs(drawer): add playground * docs(drawer): add api docs * docs: add home page (#573) * docs: add home page * docs(homepage): apply suggestions from code review * docs(homepage): make cards clickable Co-authored-by: witt <unix.bio@gmail.com> * test: update snapshots for scaleable * chore: update lock file * chore: upgrade styled-jsx * test: update snapshots for styled-jsx Co-authored-by: Deepankar <deep14bhade@gmail.com> Co-authored-by: Deepankar <statisticsaffinity@gmail.com> Co-authored-by: Florian Levis <levis.florian@gmail.com> Co-authored-by: gepd <guillermoepd@hotmail.com> Co-authored-by: Nils J <nils.jorek@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ofek Ashery <ofek.ashery@gmail.com> Co-authored-by: Sanna Jammeh <50969683+sannajammeh@users.noreply.github.com>

vercel bot deployed to Preview March 30, 2021 07:23 View deployment

ofekashery changed the title ~~feat(slider): add option to not display slider value~~ feat(slider): add option to hide slider value Mar 31, 2021

unix requested changes Mar 31, 2021

View reviewed changes

vercel bot deployed to Preview March 31, 2021 13:26 View deployment

unix changed the base branch from master to rc March 31, 2021 13:51

feat(slider): hideValue prop added

f3e0c28

unix approved these changes Mar 31, 2021

View reviewed changes

vercel bot deployed to Preview March 31, 2021 13:52 View deployment

ofekashery requested changes Mar 31, 2021

View reviewed changes

vercel bot deployed to Preview March 31, 2021 13:55 View deployment

test(slider): test added for hideValue prop

ec9c610

docs(slider): add hideValue prop docs(slider): add hideValue prop for cn docs feat(slider): ensure the dot stays round when no content test(slider): update snapshots

vercel bot had a problem deploying to Preview March 31, 2021 13:59 Failure

vercel bot deployed to Preview March 31, 2021 14:27 View deployment

ofekashery approved these changes Mar 31, 2021

View reviewed changes

ofekashery merged commit ae6b6ba into geist-org:rc Mar 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(slider): add option to hide slider value #494

feat(slider): add option to hide slider value #494

Deep-Codes commented Mar 30, 2021

codecov bot commented Mar 30, 2021 •

edited

Loading

Deep-Codes commented Mar 31, 2021

unix left a comment

unix Mar 31, 2021

Deep-Codes Mar 31, 2021

Deep-Codes Mar 31, 2021

unix commented Mar 31, 2021

ofekashery left a comment

unix commented Mar 31, 2021

unix commented Mar 31, 2021 •

edited

Loading

ofekashery commented Mar 31, 2021

feat(slider): add option to hide slider value #494

feat(slider): add option to hide slider value #494

Conversation

Deep-Codes commented Mar 30, 2021

Checklist

Change information

codecov bot commented Mar 30, 2021 • edited Loading

Codecov Report

Deep-Codes commented Mar 31, 2021

unix left a comment

Choose a reason for hiding this comment

unix Mar 31, 2021

Choose a reason for hiding this comment

Deep-Codes Mar 31, 2021

Choose a reason for hiding this comment

Deep-Codes Mar 31, 2021

Choose a reason for hiding this comment

unix commented Mar 31, 2021

ofekashery left a comment

Choose a reason for hiding this comment

unix commented Mar 31, 2021

unix commented Mar 31, 2021 • edited Loading

ofekashery commented Mar 31, 2021

codecov bot commented Mar 30, 2021 •

edited

Loading

unix commented Mar 31, 2021 •

edited

Loading