Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): support to display icons in button #179

Merged
merged 5 commits into from
May 7, 2020
Merged

feat(button): support to display icons in button #179

merged 5 commits into from
May 7, 2020

Conversation

unix
Copy link
Member

@unix unix commented May 7, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

resolved #178

this feature will be released in version v1.1.0.

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #179 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         161      162    +1     
  Lines        2013     2028   +15     
  Branches      456      463    +7     
=======================================
+ Hits         2011     2026   +15     
  Misses          2        2           
Impacted Files Coverage Δ
components/button/button-icon.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee50d8d...080ed93. Read the comment docs.

@unix unix merged commit 455e8d7 into geist-org:master May 7, 2020
@unix unix deleted the button branch May 7, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Icon support for buttons
1 participant