Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): hide icon of link component by default #180

Merged
merged 5 commits into from
May 8, 2020
Merged

feat(link): hide icon of link component by default #180

merged 5 commits into from
May 8, 2020

Conversation

unix
Copy link
Member

@unix unix commented May 8, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

resolved #175

this feature will be released in version v1.1.0.

@unix unix self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #180 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         162      162           
  Lines        2028     2031    +3     
  Branches      480      465   -15     
=======================================
+ Hits         2026     2029    +3     
  Misses          2        2           
Impacted Files Coverage Δ
components/image/image-browser.tsx 100.00% <ø> (ø)
components/user/user-link.tsx 100.00% <ø> (ø)
components/link/icon.tsx 100.00% <100.00%> (ø)
components/link/link.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf2cdf...d05cf10. Read the comment docs.

@unix unix merged commit 084e2fb into geist-org:master May 8, 2020
@unix unix deleted the link branch May 8, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link component hide icon by default
1 participant