Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snippet): add custom symbol and toast #287

Merged
merged 4 commits into from
Jun 24, 2020
Merged

feat(snippet): add custom symbol and toast #287

merged 4 commits into from
Jun 24, 2020

Conversation

AugustoConti
Copy link
Contributor

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

@AugustoConti AugustoConti changed the title Snippet feat(snippet): add custom symbol and toast Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #287 into rc will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               rc     #287   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2366     2366           
  Branches      563      563           
=======================================
  Hits         2365     2365           
  Misses          1        1
Impacted Files Coverage Δ
components/snippet/snippet.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab92e5...d7f3be0. Read the comment docs.

@AugustoConti AugustoConti changed the base branch from master to rc June 24, 2020 00:11
unix
unix requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@unix unix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍
Can you add some testcases for symbol?

components/snippet/snippet.tsx Outdated
@@ -18,6 +21,9 @@ interface Props {

const defaultProps = {
filled: false,
symbol: '$',
toastText: 'Copied to clipboard!',
toastType: 'success',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
toastType: 'success',
toastType: 'success' as NormalTypes,

@unix
Copy link
Member

unix commented Jun 24, 2020 •
edited
Loading

FOR EVERYONE:
This feature does enhance the components, I think it's a good change. If anyone else wants to contribute any features, open an issue to describe it please.
I can't make sure everyone's work can be merged, so it's necessary to communicate in advance, thank you all for efforts.

@AugustoConti AugustoConti requested a review from unix June 24, 2020 12:27
unix
unix approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@unix unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for your contribution, now it looks easier to use.

@unix unix merged commit f34da6a into geist-org:rc Jun 24, 2020
@AugustoConti AugustoConti deleted the snippet branch June 24, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unix unix unix approved these changes

Assignees

@AugustoConti AugustoConti

Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustoConti @unix