Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-complete): getPopupContainer prop #534

Closed
wants to merge 2 commits into from
Closed

feat(auto-complete): getPopupContainer prop #534

wants to merge 2 commits into from

Conversation

Bowen7
Copy link
Contributor

@Bowen7 Bowen7 commented May 9, 2021

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Add the getPopupContainer prop for AutoComplete, which already exist in Select.

@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #534 (53a7617) into master (97f44c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         183      183           
  Lines        2453     2454    +1     
  Branches      604      604           
=======================================
+ Hits         2451     2452    +1     
  Misses          2        2           
Impacted Files Coverage Δ
components/auto-complete/auto-complete.tsx 100.00% <ø> (ø)
...omponents/auto-complete/auto-complete-dropdown.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f44c8...53a7617. Read the comment docs.

@unix
Copy link
Member

unix commented Jun 5, 2021

This feature will be on hold for a while.
I'll add this feature after I resolve #531, which will probably make a big migration to the export types of the AutoComplete component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants