-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removed unnecessary code in Grid Component #633
Conversation
It is indeed feasible that. After you update the commit message and snapshot, this PR will be merged. |
Hi, so, Do I need to change the commit message with "fix:" + my message? What is the problem of the snapshot? This changes will do by the members or by me? |
52b1233
to
3cee2a0
Compare
@unix I just updated the git message |
Because the grid styles use Mobile First, the "@media only screen and (max-width: $ {theme.breakpoints.xs.max})" breakpoint is unnecessary. This generates the same styles and is applied in the same sizes as the ".xs" class. test: update snapshots
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 194 194
Lines 2930 2930
Branches 663 663
=======================================
Hits 2925 2925
Misses 5 5
Continue to review full report at Codecov.
|
Because the grid styles use Mobile First, the "@media only screen and (max-width: $ {theme.breakpoints.xs.max})" breakpoint is unnecessary. This generates the same styles and is applied in the same sizes as the ".xs" class.
Change information
I have removed the media query "@media only screen and (max-width: $ {theme.breakpoints.xs.max})". I have tested the component with and without this "media query" and I get the same results.