Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): remove fixed height of label container #727

Merged
merged 2 commits into from
Feb 12, 2022
Merged

fix(input): remove fixed height of label container #727

merged 2 commits into from
Feb 12, 2022

Conversation

jellli
Copy link
Contributor

@jellli jellli commented Feb 11, 2022

Fix Bug

issue #726

@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for geist-ui ready!

🔨 Explore the source changes: febc95e

🔍 Inspect the deploy log: https://app.netlify.com/sites/geist-ui/deploys/6207272bfcf02c00074fc1b9

😎 Browse the preview: https://deploy-preview-727--geist-ui.netlify.app

@unix unix self-assigned this Feb 12, 2022
@unix unix added the type: bug Something isn't working label Feb 12, 2022
@unix unix changed the title fix(input): remove height of input fix(input): remove fixed height of label container Feb 12, 2022
@unix unix linked an issue Feb 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #727 (febc95e) into master (c8a0d64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         198      198           
  Lines        3030     3030           
  Branches      668      668           
=======================================
  Hits         2996     2996           
  Misses         33       33           
  Partials        1        1           
Impacted Files Coverage Δ
components/input/input.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a0d64...febc95e. Read the comment docs.

@unix unix merged commit d2fc8d9 into geist-org:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input component not work well with Grid component in some way
2 participants