Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(password): pass all scale props for internally wrapped components #732

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

unix
Copy link
Member

@unix unix commented Feb 12, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

In the last update, Geist removed all scale-related props from within the component to avoid side effects, but this resulted in the internal wrapper component (e.g. Input.Password) no longer being able to pass them, and now a new function has been added to make it easier for the internal wrapper component to get native scale values.

2 test cases have also been added to check the behavior of passing native scale props.

@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for geist-ui ready!

🔨 Explore the source changes: ab5c1b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/geist-ui/deploys/6207a8443ef42900078a1f84

😎 Browse the preview: https://deploy-preview-732--geist-ui.netlify.app

@unix unix self-assigned this Feb 12, 2022
@unix unix linked an issue Feb 12, 2022 that may be closed by this pull request
@unix unix added the type: bug Something isn't working label Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #732 (ab5c1b8) into master (88f1b41) will decrease coverage by 0.02%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   98.87%   98.85%   -0.03%     
==========================================
  Files         198      198              
  Lines        3030     3045      +15     
  Branches      668      669       +1     
==========================================
+ Hits         2996     3010      +14     
- Misses         33       34       +1     
  Partials        1        1              
Impacted Files Coverage Δ
components/use-scale/with-scale.tsx 100.00% <ø> (ø)
components/use-scale/scale-context.ts 87.50% <50.00%> (-12.50%) ⬇️
components/input/password.tsx 100.00% <100.00%> (ø)
components/use-scale/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f1b41...ab5c1b8. Read the comment docs.

@unix unix merged commit 003d882 into geist-org:master Feb 12, 2022
@unix unix deleted the fix/password branch February 12, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop 'width' could not be passed correctly
1 participant