Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default side-effects to false #749

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

unix
Copy link
Member

@unix unix commented Feb 18, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Setting side-effects to false helps the automatic optimization of Webpack. Please refer to the documentation of tree-shaking for details.

@unix unix self-assigned this Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #749 (ade6764) into master (6b1fc8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      198           
  Lines        3045     3045           
  Branches      669      669           
=======================================
  Hits         3010     3010           
  Misses         34       34           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1fc8d...ade6764. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for geist-ui ready!

🔨 Explore the source changes: ade6764

🔍 Inspect the deploy log: https://app.netlify.com/sites/geist-ui/deploys/620f910cfb6ca800076dc41d

😎 Browse the preview: https://deploy-preview-749--geist-ui.netlify.app

@unix unix merged commit 8db79f6 into geist-org:master Feb 18, 2022
@unix unix deleted the feat/side-effects branch February 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant