Add BuiltinUI class #626
Open
Add BuiltinUI class #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use the built-in UI you must: 1. Start a PKCE session 2. Redirect to the built-in UI URL with the PKCE challenge This class wraps up that functionality in a simple interface. Implementations will need to save the verifier in a cookie, and redirect the user agent to the `BuiltinUIResponse.redirect_url`, and then exchange the PKCE code and verifier for a token using the normal PKCE code exchange.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a BuiltinUI class to wrap up starting a PKCE-based sign-in and sign-up flow and refactors legacy authentication code.
- Introduces BuiltinUI and AsyncBuiltinUI classes to manage PKCE generation and UI redirection.
- Refactors BaseEmailPassword to derive from a new BaseClient in gel/auth/base.py, eliminating duplicate client initialization logic.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gel/auth/email_password.py | Refactored BaseEmailPassword to inherit from BaseClient, removing custom kwargs. |
| gel/auth/builtin_ui.py | Added BuiltinUI and AsyncBuiltinUI to implement built-in UI sign-in and sign-up flows. |
| gel/auth/base.py | Introduced BaseClient to centralize HTTP client initialization and related logic. |
scotttrinh
force-pushed
the
auth-built-in-ui
branch
from
908d6f4 to
5bd621d
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
scotttrinh
force-pushed
the
auth-built-in-ui
branch
from
5bd621d to
f1047f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the built-in UI you must:
This class wraps up that functionality in a simple interface.
Implementations will need to save the verifier in a cookie, and redirect
the user agent to the
BuiltinUIResponse.redirect_url, and thenexchange the PKCE code and verifier for a token using the normal PKCE
code exchange.