ArgumentNullException when git name or email not set

[geluk]

It might be my fault, but with the new exe i get this:
ArgumentNullException (Value cannot be null. Parameter name: author)

Everything worked fine with the latest version
I just reinstalled my windows yesterday
Setup everything from clean

Originally posted by @xxxcrow in #97 (comment)

[geluk]

@xxxcrow: I suspect you haven't set your user.email and user.name configuration variables yet.
If that's the case, you can work around the issue by setting them:

git config --global user.name <name>
git config --global user.email <email>

If not, can you explain what you did when you got the error?

[xxxcrow]

@xxxcrow: I suspect you haven't set your user.email and user.name configuration variables yet. If that's the case, you can work around the issue by setting them:

git config --global user.name <name>
git config --global user.email <email>

If not, can you explain what you did when you got the error?

I actually thought git config should solve the issue, but it didn't
Firstly i had "UriFormatException" error
I knew i didn't set user.name/user.email for git
In the issue "UriFormatException" you sent a new exe file that should solve it
But with the new version a new exception showed "ArgumentNullException"
After you suggested git config --global user.name <name> git config --global user.email <email>
I changed the credentials in my git
And... it shows the same "ArgumentNullException"

[geluk]

Can you test it again with this build?
https://ci.appveyor.com/api/buildjobs/0bhld3rhklpsw5kt/artifacts/pass-winmenu%2Fbin%2FRelease%2Fpass-winmenu.exe
It won't fix your problem yet, but it should at least indicate whether missing git credentials are actually the cause of your issue. If so, you'll see an error "Could not build Git signature. Make sure 'user.name' and 'user.email' are configured for the repository.". In that case, there's an issue retrieving your Git user/email settings.

Otherwise, you'll probably get the same ArgumentNullException again. If that's the case, something else is causing your issue.

[xxxcrow]

Can you test it again with this build? https://ci.appveyor.com/api/buildjobs/0bhld3rhklpsw5kt/artifacts/pass-winmenu%2Fbin%2FRelease%2Fpass-winmenu.exe It won't fix your problem yet, but it should at least indicate whether missing git credentials are actually the cause of your issue. If so, you'll see an error "Could not build Git signature. Make sure 'user.name' and 'user.email' are configured for the repository.". In that case, there's an issue retrieving your Git user/email settings.

Otherwise, you'll probably get the same ArgumentNullException again. If that's the case, something else is causing your issue.

Ahhhmm, it worked 🙄🙄🙄
It solved all the issues
No ArgumentNullException, no anything else

Seems it was my bad again, probably after doing git config --global user.name <name> git config --global user.email <email>
i needed to restart pass-winmenu 😢

[geluk]

No problem! I'm glad it's working again. The error message you saw initially wasn't very helpful, and that has been fixed now.

[geluk]

Fixed in 1.12.1