Fix file name extension in $filename value #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration file describes $filename variable as the new file name without path and without extension, but new file dialog always shows metadata with the variable replaced by the filename with the extension.
|
Sensible suggestion, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration file describes $filename variable as the new file name without path and without extension, but the new file dialog always shows metadata with the variable replaced by the filename with the extension. Path.GetFileName function was called to obtain the $filename value but it leaves the extension untouched. I propose Path.GetFileNameWithoutExtension be called instead. Here is the screenshot of the issue:
