Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ID values for the Communication API examples #50

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

Hendrejvr
Copy link
Contributor

The API examples for the Communication calls had odd IDs like "12345" or "123450". This pull request changes that and replaces them with UUIDs.

It is, however, important to remember that the IDs are just strings.

@Hendrejvr Hendrejvr self-assigned this Aug 14, 2024
@Hendrejvr
Copy link
Contributor Author

Ich vermute, das wird durch PR 47 sowieso weitgehend erledigt, außer bei den Beispiele, die nicht vollständig sind

Update the checkout, setup-node and setup-java actions to the latest major version
Copy link
Contributor

@florianschoffke florianschoffke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Können wir die Änderungen in der Pipeline in einem separaten PR betrachten oder haben die hiermit zu tun? Sonst sollte das getrennt gemacht werden.
Die Änderungen der IDs sind mE ok.

@Hendrejvr Hendrejvr merged commit 0c0ed48 into main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants