Skip to content

Conversation

@kamladi
Copy link
Contributor

@kamladi kamladi commented Dec 17, 2025

Example prompt: summarize the messages in the thread linked in https://chat.google.com/room/{spaceId}/{threadId}/{messageId}

Previously, this prompt would result in a failure, as the tool could only paginate across all messages in the space, and was not able to filter by a thread ID. This change allows this type of prompt to succeed, as the tool can now include a threadID filter in the Chat API request.

  • Introduces a new optional param threadName to the tool description for chat.getMessages with a description including a sample thread name.
  • Updates the ChatService.getMessages function to include a threadName param. If defined, the threadname is included in the "filter" param for the Chat API request.
  • Added unit tests

- Introduces a new optional param `threadName` to the tool description
for `chat.getMessages` with a description including a sample thread
name.
- Updates the `ChatService.getMessages` function to include a threadName
param. If defined, the threadname is included in the "filter" param for
the Chat API request.
- Added unit tests
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kamladi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the chat.getMessages tool by introducing the capability to filter messages by a specific thread name. Previously, the tool could only fetch messages across an entire space, limiting its utility for targeted requests. With this change, users can now accurately query and summarize messages within a particular thread, improving the tool's precision and responsiveness to more complex prompts. The update involves modifications to the tool's input schema, the ChatService logic for constructing API requests, and comprehensive unit tests to ensure correct functionality.

Highlights

  • Thread Filtering Support: The chat.getMessages tool now supports filtering messages by a specific thread name, enhancing its ability to retrieve targeted information.
  • Enhanced Prompt Handling: This change enables successful processing of prompts that require summarizing messages within a linked thread, addressing a previous limitation where such requests would fail.
  • API Parameter Addition: An optional threadName parameter has been introduced to the chat.getMessages tool description and the ChatService.getMessages function, allowing users to specify a thread for filtering.
  • Filter Logic Update: The ChatService.getMessages function has been updated to construct the Chat API request filter to include the threadName when provided, and can now combine it with other filters like unreadOnly using logical AND.
  • Unit Test Coverage: New unit tests have been added to validate the threadName filtering functionality, including scenarios where it's combined with the unreadOnly filter, ensuring robustness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kamladi kamladi changed the title Update chat.getMessages tool to support filtering by thread name feat(chat): Update chat.getMessages tool to support filtering by thread name Dec 17, 2025
@kamladi kamladi changed the title feat(chat): Update chat.getMessages tool to support filtering by thread name feat(chat): update chat.getMessages tool to support filtering by thread name Dec 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for filtering messages by thread name in the chat.getMessages tool. The changes are well-implemented, including updates to the service layer to build the filter query, modifications to the tool definition, and new unit tests to cover the functionality. The approach of using a filters array is scalable for future additions. I have one suggestion to improve code maintainability.

@kamladi kamladi marked this pull request as ready for review December 18, 2025 00:37
Copy link
Contributor

@allenhutchison allenhutchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the contribution!

@allenhutchison allenhutchison merged commit 5d85451 into gemini-cli-extensions:main Dec 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants