-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add version syncing scripts and hooks #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a comprehensive solution for synchronizing version numbers across various project files. By introducing a dedicated script and integrating it with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful mechanism for synchronizing version numbers across multiple files using npm's version lifecycle hook. The implementation is straightforward and the logic is sound. The update to the release.js script to use the package.json version as a fallback is also a good improvement.
I've added a couple of suggestions for the new scripts/set-version.js file to improve its robustness with better error handling and to make a minor performance optimization. Overall, this is a solid addition to the project's tooling.
This PR introduces a mechanism to keep version strings in sync across the codebase using the
npm versionlifecycle hook.Changes
scripts/set-version.jsto update versions in:package.jsonworkspace-server/package.jsonworkspace-server/src/index.tspackage.jsonto includeset-versionandversionscripts.scripts/release.jsto fallback topackage.jsonversion ifGITHUB_REF_NAMEis missing.How to Test
npm run set-version 0.0.2and verify all files are updated.npm version patchand verify it creates a commit with all files updated.npm run releaseand verify the output json has the correct version.Fixes #27