Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): update q-io to v2 #4

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

tx44
Copy link
Contributor

@tx44 tx44 commented Nov 6, 2017

Let's update to the latest q-io, cause "q-io": "^1.13.2" depends on old version of collections ("^0.2.0"), which awfully patches Array.prototype methods directly:
https://github.com/montagejs/collections/blob/v0.2.2/shim-array.js#L118

Furthermore, it has incompatible for today find method:
https://github.com/montagejs/collections/blob/v0.2.2/shim-array.js#L125

The problem is known, and authors suggests to use collections v2:
montagejs/collections#178 (comment)

F.ex. another gemini plugin, gemini-coverage, works well with q-io v2:
https://github.com/gemini-testing/gemini-coverage/blob/master/package.json#L14

Usage of this dependency causes unpredictable behaviour further on the stack. F.ex. in arui-feather we are using gemini-react with bunch of postcss plugins, and one of them, postcss-url breaks styles with this condition.

alfa-laboratory/arui-feather#202

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 211d4e7 on teryaew:feat/update-q-io-to-v2 into 42354f8 on gemini-testing:master.

@sipayRT
Copy link
Member

sipayRT commented Nov 6, 2017

thanks!

@sipayRT
Copy link
Member

sipayRT commented Nov 6, 2017

v1.1.0

@tx44 tx44 deleted the feat/update-q-io-to-v2 branch November 6, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants