This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
feat: remove backwards compatibility for passing grep to readTests #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0tunn
force-pushed
the
feat/read.grep
branch
from
e81ed8e to
53b9815
Compare
j0tunn
force-pushed
the
feat/read.grep
branch
from
53b9815 to
a853503
Compare
j0tunn
changed the title
sipayRT
suggested changes
Nov 3, 2017
lib/gemini.js
Outdated
| @@ -89,16 +89,6 @@ module.exports = class Gemini extends PassthroughEmitter { | |||
| } | |||
|
|
|||
| readTests(paths, options) { | |||
There was a problem hiding this comment.
options = {}. Ниже ты удалил дефолтное значение. Оно, конечно, будет работать, но лучше явно указать
j0tunn
force-pushed
the
feat/read.grep
branch
from
a853503 to
ed4ece5
Compare
sipayRT
approved these changes
Nov 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.