fix(ct): correctly works with vite-style imports #1169
Conversation
commit: |
| "ts-node": ">=10.5.0" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "@babel/parser": { |
There was a problem hiding this comment.
I use @babel/parser because I can't implement a plugin for esbuild when use transformSync in order to remove vite-style imports. For swc I can implement it in Rust, but it won't be a complete solution.
In next major we should move to use only swc parser.
| registerTransformHook(this.isWorker()); | ||
|
|
||
| this._config = Config.create(config); | ||
| updateTransformHook(this._config); |
There was a problem hiding this comment.
I need config in order to check if tests run in node env or in browser env
| const isJsxOrTsx = extname === ".jsx" || extname === ".tsx"; | ||
|
|
||
| if (!isJsxOrTsx) { | ||
| return code; |
There was a problem hiding this comment.
do nothing if file is not jsx or tsx
| if (typeof source === "string") { | ||
| const extname = path.extname(source); | ||
|
|
||
| if (extname && extname.includes("?")) { |
There was a problem hiding this comment.
Remove only imports which has query symbol in extension name, like - file.svg?react
| ); | ||
| return code; | ||
| } | ||
| } |
There was a problem hiding this comment.
Unfortunately, this file is not covered by tests, as it requires integration tests, but we do not have a ready infrastructure for them.
What is done:
Implement ability to remove vite-style imports with query parameters when parse .jsx and .tsx files in node. More info about these imports here - https://vite.dev/guide/assets#explicit-url-imports.
Problem reproduced when using vite-plugin-svgr - https://github.com/pd4d10/vite-plugin-svgr