[IDE] Update paths to resources when a container is renamed #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because:
- renaming a project or a container is likely to corrupt the whole ALE environment
How:
- a RenameParticipant listens for renaming events and triggers:
- a change that updates paths to resources in .dsl files
- a change that updates paths to resources in project's preferences
Side changes:
- AleAware.getEnvironment() does not return a Normalized instance anymore.
Normalized was turning each behavior URI into an absolute file path, making
code in Rename participants cumbersome.
DslBuilder is instead charged of turning URI into files before feeding them to ANTLR.
Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
force-pushed
the
70-paths-to-resources-not-updated-when-the-project-is-renamed
branch
from
de872ba to
88e299f
Compare
echebbi
deleted the
70-paths-to-resources-not-updated-when-the-project-is-renamed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70.
Changes
Demo
Click to show
Change preview
I also wanted to implement a preview of the changes (in a textual diff) but I found no code to reuse and that would thus have costed too much time. The steps are:
org.eclipse.ltk.ui.refactoring.changePreviewViewersextension pointorg.eclipse.ltk.ui.refactoring.IChangePreviewViewerOther changes
Normalizedinstance anymore.Normalizedwas turning each source file URI into an absolute file path, making code in Rename participants cumbersome.DslBuilderis instead charged of turning URI into files before feeding them to ANTLR.Those details will be clean up by #123
Comments
@dvojtise I believe that the code updating the .dsl file could (and should?) be moved to the GEMOC Studio. Kind of related to eclipse-gemoc/gemoc-studio#161