Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pflotran output #558

Merged
merged 9 commits into from
Jan 27, 2022
Merged

Conversation

MoiseRousseau
Copy link
Contributor

Description

Add two new export formats: PFLOTRAN (export_pflotran_input) and FLAC3D (export_flac3D_input).
Also add a function which create the vertices coordinates and the block defined by their vertices id.

Relates to #557

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@MoiseRousseau
Copy link
Contributor Author

Note the PFLOTRAN output may need the h5py library to enable hdf5 output format. I did not change the dependencies and installed h5py on my own.

@Leguark
Copy link
Member

Leguark commented Feb 4, 2021

Hi @MoiseRousseau sorry for the very late response. Thank you for your contribution!

Can you add a small test (probably in gempy/test/test_addons/test_export) also can help to know how to use the function

@MoiseRousseau
Copy link
Contributor Author

Hi @Leguark !
Sorry also for the late response. I am currently in the last month of my PhD so I did not have so much time right now.
I would have a look to the small test you ask soon. Also, to help know how to use the function, I could write a piece a documentation as it is done for the MOOSE exportation capability under the "integration" folder (https://docs.gempy.org/integrations/gempy_export_MOOSE.html).
Have a nice day!
Moise

@MoiseRousseau
Copy link
Contributor Author

Hi @Leguark,
I finally update the exportation function and provided an example in the integrations folder. Now, exporting a PFLOTRAN mesh is automatically documented in the integrations section.
Please let me know what you think and if it can be merged.
Have a nice day,
Moise

Copy link
Collaborator

@Japhiolite Japhiolite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, we'll maybe have to write one, two small tests for the export functions.

@Japhiolite Japhiolite merged commit 428158d into gempy-project:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new export format: PFLOTRAN r(eactive transport code) and FLAC3D (geomechanics)
3 participants