Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken PyVista import #611

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Fix broken PyVista import #611

merged 3 commits into from
Sep 16, 2021

Conversation

banesullivan
Copy link
Contributor

@banesullivan banesullivan commented Jun 8, 2021

Description

Fixes broken PyVista/PyVistaQt import with latest releases.

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@banesullivan
Copy link
Contributor Author

banesullivan commented Jun 8, 2021

I did not actually test this... Just my thought on how to fix it since this code moved recently in PyVista and is no longer located in the pyvista.plotting.theme submodule. It should be accessible from pyvista.plotting directly across versions though

Pretty sure the breaking change happened in pyvista/pyvista#1310

@banesullivan
Copy link
Contributor Author

PyVistaQt switched to using QtPy to allow any Qt backend. I added pyqt5 as a dependency here so that QtPy has Qt bindings to leverage.

@banesullivan
Copy link
Contributor Author

Feel free to use a different PyQt backend per https://github.com/spyder-ide/qtpy#requirements

@AlexanderJuestel AlexanderJuestel changed the base branch from master to dev_alexj September 16, 2021 06:16
@AlexanderJuestel AlexanderJuestel merged commit 8e7b09a into gempy-project:dev_alexj Sep 16, 2021
@AlexanderJuestel AlexanderJuestel mentioned this pull request Sep 16, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants