Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove inplace for pandas cat #799

Merged
merged 21 commits into from
Jun 2, 2023

Conversation

Japhiolite
Copy link
Collaborator

Description

inplace=True has been deprecated completely with Pandas 2.0. I think Alex started changing this in the past, but the changes (or I misremember) are not present in this branch.

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • [ x ] I have created tests which entirely cover my code.
  • [ x ] The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • [ x ] New and existing tests pass locally with my changes.

@Japhiolite
Copy link
Collaborator Author

ok, pip tests are now passing...but some unit tests will fail again with pandas 2.0.2 (now testing environment is 2.0.1)...
haven't looked into this yet

@Japhiolite Japhiolite merged commit 28dcdc1 into gempy_v2023.1.0 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants