feat: stargate receiver #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuchmenko
commented
Jan 24, 2025
•
kuchmenko
commented
- Implement starage receive lzCompose contract
- Add multicalls handling
- Deployment docs + .env.example
gemcoder21
approved these changes
Jan 24, 2025
|
Things to improve:
I will work on 3 |
gemcoder21
approved these changes
Jan 27, 2025
|
can you rename folder |
0xh3rman
reviewed
Jan 28, 2025
Co-authored-by: Ferman <119309671+0xh3rman@users.noreply.github.com>
0xh3rman
reviewed
Jan 30, 2025
| * @notice A contract that handles multiple calls in a single transaction. | ||
| * @dev Inspired by https://github.com/across-protocol/contracts/blob/master/contracts/handlers/MulticallHandler.sol | ||
| */ | ||
| contract MulticallHandler { |
There was a problem hiding this comment.
across's handler has MulticallHandler but i can't see it on here or GemStargateMulticallHandler
|
|
||
| struct Instructions { | ||
| // Added to handle | ||
| address token; |
There was a problem hiding this comment.
can we handle this in composeMsg? Instructions is better to be as generic as possible
Comment on lines
+30
to
+32
| // call across | ||
|
|
||
| // Rest from across |
There was a problem hiding this comment.
Suggested change
| // call across | |
| // Rest from across |
| echo "✅ Deployment to $NETWORK_NAME completed." | ||
| done | ||
|
|
||
| echo "🎉 All non-zkSync deployments done!" |
There was a problem hiding this comment.
lol, why zkSync is so special, deploy/deploy-stargate.sh and deploy/deploy-stargate-zksync.sh should be more proper naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.