Fixes for Windows #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_MSC_VER doesn't work with mingw, use _WIN32 instead Windows header is windows.h (for case sensitivity) ignore unarr.exe as well fix interaction with CRT + GCC style forceinline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_MSC_VER doesn't work with mingw, use _WIN32 instead. This caused files above 2GB to not work on go-unarr. I didn't write a test for this since it would probably complicate tests too much.
Windows header is windows.h (for case sensitivity). This caused Linux cross compilation to fail.
Ignore unarr.exe as well. This is produced from the one the fly build instructions, so we should ignore it.
Fix interaction with GCC style forceinline being redefined.
selmf/unarr#20