Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy static type checker #96

Merged
merged 45 commits into from
Nov 29, 2024
Merged

Add mypy static type checker #96

merged 45 commits into from
Nov 29, 2024

Conversation

samuelrince
Copy link
Member

@samuelrince samuelrince commented Nov 23, 2024

Many changes in this PR to make sure we properly type the package.

Each commit represents a fix of one "type" of issues related to mypy error reports.

Implements #90

Also based on https://github.com/NP4567-dev/ecologits/tree/feature/mypy

NP4567-dev
NP4567-dev previously approved these changes Nov 23, 2024
Copy link
Collaborator

@NP4567-dev NP4567-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ecologits/model_repository.py Outdated Show resolved Hide resolved
ecologits/impacts/modeling.py Show resolved Hide resolved
@samuelrince samuelrince merged commit 08a3703 into main Nov 29, 2024
2 checks passed
@samuelrince samuelrince deleted the refactor/mypy branch November 29, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants