Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (particularly crc 3.0.0) #78

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

chyyran
Copy link
Contributor

@chyyran chyyran commented Aug 9, 2022

Pull Request Overview

This pull request adds/changes/fixes...

  • Updates byteorder to 1.4.3
  • Updates log to 0.4.17
  • Updates env_logger to 0.9.0
  • Updates crc to 3.0.0
    • crc from ^1.0.0 -> 3.0.0 represents a very large API change. In particular, algorithms are now const-initialized and Digest no longer implements Hash, so Write/Read for DigestWrite/Read (formerly HasherWrite/Read) has to be implemented per type. This results in most of the code changes in this PR.
    • The particular selection of CRC polynomials are consistent with the old version of crc and the XZ specification. See CRC-64/XZ and and CRC-32/ISO-HDLC in the catalogue of parameterised CRC algorithms.

Testing Strategy

This pull request was tested by ...

  • The existing tests are sufficient and should all pass

@chyyran chyyran force-pushed the patch-update-crc branch 3 times, most recently from a11e8d9 to 110700b Compare August 9, 2022 04:05
src/decode/util.rs Outdated Show resolved Hide resolved
src/encode/util.rs Outdated Show resolved Hide resolved
src/decode/util.rs Outdated Show resolved Hide resolved
src/decode/util.rs Outdated Show resolved Hide resolved
src/encode/util.rs Outdated Show resolved Hide resolved
src/encode/util.rs Outdated Show resolved Hide resolved
src/decode/util.rs Outdated Show resolved Hide resolved
src/encode/util.rs Outdated Show resolved Hide resolved
Copy link
Owner

@gendx gendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good change, with some minor comments.

Cargo.toml Show resolved Hide resolved
src/decode/util.rs Outdated Show resolved Hide resolved
src/decode/xz.rs Outdated Show resolved Hide resolved
@chyyran chyyran force-pushed the patch-update-crc branch 2 times, most recently from c6704c1 to e51f885 Compare August 24, 2022 01:58
@chyyran chyyran requested a review from gendx August 24, 2022 01:59
@chyyran
Copy link
Contributor Author

chyyran commented Aug 24, 2022

Addressed the nits and rebased on master. See follow up comment on reasoning for CrcDigestRead/Write.

src/xz/header.rs Outdated Show resolved Hide resolved
@gendx
Copy link
Owner

gendx commented Aug 26, 2022

In the meantime I've merged #82 which addresses the import formatting question.

Could you rebase on top of it to resolve the merge conflict?

@chyyran
Copy link
Contributor Author

chyyran commented Aug 26, 2022

Rebased on master in 698620b

@gendx gendx merged commit c80e4aa into gendx:master Aug 26, 2022
@chyyran chyyran deleted the patch-update-crc branch November 1, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants