-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies (particularly crc 3.0.0) #78
Conversation
a11e8d9
to
110700b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a good change, with some minor comments.
c6704c1
to
e51f885
Compare
Addressed the nits and rebased on master. See follow up comment on reasoning for |
e51f885
to
4d800af
Compare
4d800af
to
7f8d36f
Compare
In the meantime I've merged #82 which addresses the import formatting question. Could you rebase on top of it to resolve the merge conflict? |
7f8d36f
to
698620b
Compare
Rebased on master in 698620b |
Pull Request Overview
This pull request adds/changes/fixes...
byteorder
to1.4.3
log
to0.4.17
env_logger
to0.9.0
crc
to3.0.0
crc
from^1.0.0
->3.0.0
represents a very large API change. In particular, algorithms are now const-initialized andDigest
no longer implementsHash
, soWrite/Read
forDigestWrite/Read
(formerlyHasherWrite/Read
) has to be implemented per type. This results in most of the code changes in this PR.crc
and the XZ specification. See CRC-64/XZ and and CRC-32/ISO-HDLC in the catalogue of parameterised CRC algorithms.Testing Strategy
This pull request was tested by ...