Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAD(P) metabolic process terms #29050

Open
5 of 7 tasks
sjm41 opened this issue Oct 11, 2024 · 17 comments
Open
5 of 7 tasks

NAD(P) metabolic process terms #29050

sjm41 opened this issue Oct 11, 2024 · 17 comments

Comments

@sjm41
Copy link
Contributor

sjm41 commented Oct 11, 2024

We currently have this arrangement:

NAD metabolic process
|__NAD biosynthetic process
|__NAD catabolic process
|__NADH metabolic process
    |__NADH oxidation
    |__NADH regeneration

NADP metabolic process
|__NADP biosynthetic process
|__NADP catabolic process
|__NADPH oxidation
|__NADPH regeneration

And here are the terms:

id: GO:0019674
name: NAD metabolic process
def: "The chemical reactions and pathways involving nicotinamide adenine dinucleotide (NAD), a coenzyme present in most living cells and derived from the B vitamin nicotinic acid." [GOC:jl, ISBN:0618254153]
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input_or_output CHEBI:13389 ! NAD
property_value: term_tracker_item "#21577" xsd:anyURI
property_value: term_tracker_item "#23467" xsd:anyURI

id: GO:0009435
name: NAD biosynthetic process
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide, a coenzyme present in most living cells and derived from the B vitamin nicotinic acid; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH." [GOC:jl, ISBN:0618254153]
intersection_of: GO:0009058 ! biosynthetic process
intersection_of: has_primary_output CHEBI:13389 ! NAD
property_value: term_tracker_item "#21577" xsd:anyURI

id: GO:0019677
name: NAD catabolic process
def: "The chemical reactions and pathways resulting in the breakdown of nicotinamide adenine dinucleotide, a coenzyme present in most living cells and derived from the B vitamin nicotinic acid; catabolism may be of either the oxidized form, NAD, or the reduced form, NADH." [GOC:jl, ISBN:0618254153]
intersection_of: GO:0009056 ! catabolic process
intersection_of: has_primary_input CHEBI:13389 ! NAD
property_value: term_tracker_item "#21577" xsd:anyURI

id: GO:0006734 (28 direct EXP annotations)
name: NADH metabolic process
def: "The chemical reactions and pathways involving reduced nicotinamide adenine dinucleotide (NADH), a coenzyme present in most living cells and derived from the B vitamin nicotinic acid." [GOC:jl, ISBN:0618254153]
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input_or_output CHEBI:57945 ! NADH(2-)

id: GO:0006116 (25 direct EXP annotations)
name: NADH oxidation
def: "A metabolic process that results in the oxidation of reduced nicotinamide adenine dinucleotide, NADH, to the oxidized form, NAD+." [GOC:ai]
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input CHEBI:57945 ! NADH(2-)
intersection_of: has_primary_output CHEBI:57540 ! NAD(1-)
property_value: term_tracker_item "#21577" xsd:anyURI

id: GO:0006735 (9 direct EXP annotations)
name: NADH regeneration
def: "A metabolic process that generates a pool of NADH by the reduction of NAD+." [GOC:mah]
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_output CHEBI:57945 ! NADH(2-)
intersection_of: has_primary_input CHEBI:57540 ! NAD(1-)
intersection_of: has_primary_output CHEBI:57945 ! NADH(2-)


id: GO:0006739
name: NADP metabolic process
def: "The chemical reactions and pathways involving nicotinamide-adenine dinucleotide phosphate, a coenzyme involved in many redox and biosynthetic reactions; metabolism may be of either the oxidized form, NADP, or the reduced form, NADPH." [GOC:mah]
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input_or_output CHEBI:58349 ! NADP(3-)
property_value: term_tracker_item "#23467" xsd:anyURI

id: GO:0006741
name: NADP biosynthetic process
def: "The chemical reactions and pathways resulting in the formation of nicotinamide-adenine dinucleotide phosphate, a coenzyme involved in many redox and biosynthetic reactions; biosynthesis may be of either the oxidized form, NADP, or the reduced form, NADPH." [GOC:mah]
intersection_of: GO:0009058 ! biosynthetic process
intersection_of: has_primary_output CHEBI:58349 ! NADP(3-)

id: GO:0006742
name: NADP catabolic process
def: "The chemical reactions and pathways resulting in the breakdown of nicotinamide-adenine dinucleotide phosphate, a coenzyme involved in many redox and biosynthetic reactions; catabolism may be of either the oxidized form, NADP, or the reduced form, NADPH." [GOC:mah]
intersection_of: GO:0009056 ! catabolic process
intersection_of: has_primary_input CHEBI:58349 ! NADP(3-)

id: GO:0070995 (16 direct EXP annotations)
name: NADPH oxidation
def: "A metabolic process that results in the oxidation of reduced nicotinamide adenine dinucleotide, NADPH, to the oxidized form, NADP." [GOC:BHF, GOC:mah]
is_a: GO:0006739 ! NADP metabolic process
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input CHEBI:57783 ! NADPH(4-)
intersection_of: has_primary_output CHEBI:58349 ! NADP(3-)

id: GO:0006740 (24 direct EXP annotations)
name: NADPH regeneration
def: "A metabolic process that generates a pool of NADPH by the reduction of NADP+." [GOC:mah]
is_a: GO:0006091 ! generation of precursor metabolites and energy
is_a: GO:0006739 ! NADP metabolic process
intersection_of: GO:0008152 ! metabolic process
intersection_of: has_primary_input CHEBI:58349 ! NADP(3-)
intersection_of: has_primary_output CHEBI:57783 ! NADPH(4-)


I think there are several issues to address here:

  • In all these defs, "the oxidized form" should be reported as 'NAD+' or ''NADP+' rather than just 'NAD' or 'NADP'.

  • For the 'NAD metabolic process' term def, should add "metabolism may be of either the oxidized form, NAD+, or the reduced form, NADH." to match the defs of the child 'NAD biosynthetic/catabolic process' terms as well as the def of the equivalent 'NADP metabolic process' term.

  • Implementing the point above would make the "NADH metabolic process" term redundant, so it should be obsoleted (or rather merged into the parent 'NAD metabolic process' term). Doing so would also then match how the NADP branch is already organised.

  • As alluded to in malate-aspartate shuttle parentage #27924, "NADH oxidation" and "NADPH oxidation" are just inevitable consequences of these factors acting as co-enzymes for oxidoreductase enzymes - I can't see any utility in having these terms (as defined), since they could be applied to any oxidoreductase reaction using NAD(P)H and operating in the reductase direction. Suggest these two terms are obsoleted.

  • Change the primary_input/output chemical on the NAD metabolic/biosynthesis/catabolic terms from 'CHEBI:13389 ! NAD' to 'CHEBI:57540 ! NAD(1-)' to be consistent with how this is reported in the other terms mentioned above. (This was meant to be fixed in Change logical definition of 'GO:0019674 NAD metabolic process #23467, but doesn't look like it actually happened.)

  • The LD of the 'NADH regeneration' term has the same CHEBI as both 'has_output' and 'has_primary_output' - remove the former.

  • The 'NADPH regeneration' term appears to have a "is_a: GO:0006739 ! NADP metabolic process" relation that is redundant with the LD - need to check and remove if so.

I found PMID:28648096 is a good general review of NAD(H) and NADP(H) biology, including synthetic pathways.

@rozaru @deustp01 @ukemi

See also ticket #24279

@rozaru
Copy link

rozaru commented Dec 19, 2024

The NAD biosynthetic process branch will need some updating too.

NAD biosynthetic process
    |__'de novo' NAD biosynthetic process
    |   |__'de novo' NAD biosynthetic process from aspartate
    |   |__'de novo' NAD biosynthetic process from tryptophan(+ regulatory terms)
    |__NAD biosynthesis via nicotinamide riboside salvage pathway
    |__NAD salvage

This is how the GO terms fits into the various pathways known to make NAD.

image

There are various issues:

  1. term definitions needs to be updated
  2. some Xref to MetacCyc are missing
  3. misplaced terms

For the parent:

GO:0009435 NAD biosynthetic process
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide, a coenzyme present in most living cells and derived from the B vitamin nicotinic acid; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

  • the definition is too restrictive and doesn’t mention the alternative routes
  • vitamin B3 would be the correct term and this term normally includes various forms including nicotinamide and nicotinic acid (nicotinate)

Proposal 1:

def:"The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), a coenzyme present in most living cells; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

Proposal 2:

def:"The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), a coenzyme present in most living cells and is derived from various sources including vitamin B3; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."


For these 2 terms:

GO:0034628 'de novo' NAD biosynthetic process from aspartate
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the synthesis of aspartate from simpler precursors; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

GO:0034354 'de novo' NAD biosynthetic process from tryptophan
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the synthesis of tryptophan from simpler precursors; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

  • both definitions “beginning with the synthesis of aspartate/tryptophane”. This is incorrect as it is their catabolism that provides the precursor quinolinate for NAD biosynthesis
  • normally it's L-aspartate and L-tryptophan

Proposal:

GO:0034628 'de novo' NAD biosynthetic process from L-aspartate
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the catabolism of L-aspartate into the precursor quinolinate; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

GO:0034354 'de novo' NAD biosynthetic process from L-tryptophan
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the catabolism of L-tryptophan into the precursor quinolinate; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."


For these terms:

GO:0034355 NAD salvage
def: "Any process that generates nicotinamide adenine dinucleotide (NAD) from derivatives of it, without de novo synthesis; salvage is usually from the degradation products nicotinic acid (Na) and nicotinamide (Nam)."

  • “from the degradation products...” it’s probably true but they are mostly acquired from the diet
  • the term name may be updated
  • In the literature, the production of NAD from nicotinate (nicotinic acid) is called the Preiss-Handler pathway, some authors include it in the salvage pathway other not. For the moment the NAD salvage GO term includes it.

Proposal:

GO:0034355 NAD salvage biosynthetic process
Def: Any process that generates nicotinamide adenine dinucleotide (NAD) from vitamin B3 derivatives including nicotinic acid (NA) and nicotinamide (NAM), without de novo synthesis. NAD can also be produced from beta-nicotinamide D-ribonucleotide (NMN) or beta-nicotinamide D-riboside (NR).

GO:0034356 NAD biosynthesis via nicotinamide riboside salvage pathway
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD) from the vitamin precursor nicotinamide riboside."

  • it should be a child of GO:0034355 NAD salvage
  • Should this term be kept or merged to NAD salvage?
  • If the term is kept the name and the definition will need to be updated and the other compounds would need their own GO term

@pgaudet
Copy link
Contributor

pgaudet commented Dec 20, 2024

Hi @rozaru

Maybe GO:0034355 NAD biosynthetic process by/via (the) salvage pathway sounds less GO-speak?

@rozaru
Copy link

rozaru commented Dec 20, 2024

@pgaudet
I like your suggestion "NAD biosynthetic process via the salvage pathway", it works better.

@ukemi
Copy link
Contributor

ukemi commented Jan 30, 2025

@tberardini , the proposal is to implement the above changes with the NADP branch of GO as well. I thought it would be good to check with you since IIRC (I might be wrong) NADP is the more prominent metabolite in plants than it is in animals.

@rozaru
Copy link

rozaru commented Feb 3, 2025

After discussion with @ukemi and @deustp01, the following updates are proposed which take into account the comments above.

The changes involve:

  • updating GO term name, definition, output/input and MetaCyc Xref (see below)
  • making the following GO terms obsolete (see below)
    |__NADH metabolic process
    | |__NADH oxidation
    | |__NADH regeneration
  • making the 2 shuttle terms direct children of NAD metabolic process
    NAD+ metabolic process
    |__glycerophosphate shuttle
    |__malate-aspartate shuttle
  • finding a new place for "sulphoglycolysis" in the ontology (see below)

The NADP metabolic branch will be look at later and may involve further changes.

Current NAD branch:

NAD metabolic process
    |__NAD biosynthetic process
    |   |__'de novo' NAD biosynthetic process
    |   |   |__'de novo' NAD biosynthetic process from aspartate
    |   |   |__'de novo' NAD biosynthetic process from tryptophan(+)
    |   |__NAD biosynthesis via nicotinamide riboside salvage pathway
    |   |__NAD salvage
    |__NAD catabolic process
    |   |__canonical glycolysis
    |__NADH metabolic process TO REMOVE
    |   |__NADH oxidation TO REMOVE
    |   |   |__glycerophosphate shuttle DIRECT CHILD OF NAD MET PRO
            |   |   |__malate-aspartate DIRECT CHILD OF NAD MET PRO
            |   |__NADH regeneration TO REMOVE
            |   |   |__canonical glycolysis
            |   |__sulphoglycolysis TO REMOVE
    |__regulation of NAD metabolic process

Updated NAD branch:

NAD+ metabolic process
        |__NAD+ biosynthetic process
        |   |__'de novo' NAD+ biosynthetic process
        |   |   |__'de novo' NAD+ biosynthetic process from aspartate
        |   |   |__'de novo' NAD+ biosynthetic process from tryptophan(+)
        |   |__NAD+ salvage
        	|__NAD+ biosynthesis via nicotinamide riboside salvage pathway            
        |__NAD+ catabolic process
        |__glycerophosphate shuttle
        |__malate-aspartate shuttle 
        |__regulation of NAD+ metabolic process

Terms to update

  • GO:0019674 NAD metabolic process

From:

def: "The chemical reactions and pathways involving nicotinamide adenine dinucleotide (NAD), a coenzyme present in most living cells and derived from the B vitamin nicotinic acid." [GOC:jl, ISBN:0618254153]
intersection_of: has_primary_input_or_output CHEBI:13389 ! NAD

To:
def: "The chemical reactions and pathways involving nicotinamide adenine dinucleotide (NAD), a coenzyme involved in many redox and catabolic reactions; metabolism may be of either the oxidized form, NAD+, or the reduced form, NADH." [GOC:jl, ISBN:0618254153]
intersection_of: has_primary_input_or_output CHEBI:57540 ! NAD(1−)


  • GO:0009435 NAD biosynthetic process

From:

def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide, a coenzyme present in most living cells and derived from the B vitamin nicotinic acid; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

To:
def:"The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), a coenzyme involved in many redox and catabolic reactions and is derived from various sources including vitamin B3; biosynthesis may be of either the oxidized form, NAD+, or the reduced form, NADH."
intersection_of: has_primary_output CHEBI:57540] ! NAD(1−)


  • GO:0034628 'de novo' NAD biosynthetic process from aspartate

From:

def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the synthesis of aspartate from simpler precursors; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

To:
name: 'de novo' NAD biosynthetic process from L-aspartate
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the catabolism of L-aspartate into the precursor quinolinate; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."
comment: This pathway is found in bacteria, Archae and may also occur in plants.
intersection_of: has_primary_input CHEBI:29991 ! L-aspartate(1−)
intersection_of: has_primary_output CHEBI:25527 ! CHEBI:57540 ! NAD(1−)
MetaCyc: PYRIDNUCSYN-PWY
MetaCyc: PWY-8352
MetaCyc: PWY-8277


  • GO:0034354 'de novo' NAD biosynthetic process from tryptophan

From:

def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the synthesis of tryptophan from simpler precursors; biosynthesis may be of either the oxidized form, NAD, or the reduced form, NADH."

To:
name: 'de novo' NAD biosynthetic process from L-tryptophan
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD), beginning with the catabolism of L-tryptophan into the precursor quinolinate; biosynthesis may be of either the oxidized form, NAD+, or the reduced form, NADH."
comment: This pathway is found in eukaryotes.
intersection_of: has_primary_input CHEBI:57912 ! L-tryptophan zwitterion
intersection_of: has_primary_output CHEBI:25527 ! CHEBI:57540 ! NAD(1−)
MetaCyc: NADSYN-PWY
MetaCyc: PWY-5653

  • The regulatory children terms need to be updated to:

id: GO:1905012
name: regulation of 'de novo' NAD biosynthetic process from L-tryptophan
def: "Any process that modulates the frequency, rate or extent of 'de novo' NAD biosynthetic process from L-tryptophan."

id: GO:1905013
name: negative regulation of 'de novo' NAD biosynthetic process from L-tryptophan
namespace: biological_process
def: "Any process that stops, prevents or reduces the frequency, rate or extent of 'de novo' NAD biosynthetic process from L-tryptophan."

id: GO:1905014
name: positive regulation of 'de novo' NAD biosynthetic process from L-tryptophan
namespace: biological_process
def: "Any process that activates or increases the frequency, rate or extent of 'de novo' NAD biosynthetic process from L-tryptophan."


  • GO:0034355 NAD salvage

From:

def: "Any process that generates nicotinamide adenine dinucleotide (NAD) from derivatives of it, without de novo synthesis; salvage is usually from the degradation products nicotinic acid (Na) and nicotinamide (Nam)."

To:
name: NAD biosynthetic process via the salvage pathway (or keep the original name?)
Def: Any process that generates nicotinamide adenine dinucleotide (NAD) from vitamin B3 derivatives including nicotinic acid (NA) and nicotinamide (NAM), without de novo synthesis. NAD can also be produced from beta-nicotinamide D-ribonucleotide (NMN), nicotinamide riboside (NR) or nicotinate riboside (NAR).
intersection_of: has_primary_output CHEBI:57540 ! NAD(1−)
MetaCyc: NAD-BIOSYNTHESIS-III (nicotinamide, bacteria)
MetaCyc: PWY-8511 (nicotinate, bacteria, eukaryote)
MetaCyc: PWY-5381 (cycle, plants)
MetaCyc: PYRIDNUCSAL-PWY (cycle, bacteria)
MetaCyc: PWY-7761 (cycle, bacteria)
MetaCyc: PWY3O-4107 (nicotinate, cycle, eukaryotes, Preiss-Handler pathway)


  • GO:0034356 NAD biosynthesis via nicotinamide riboside salvage pathway

This should be a child of GO:0034355 NAD salvage.

From:

def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD) from the vitamin precursor nicotinamide riboside."

To:
name: GO:0034356 NAD biosynthetic process via nicotinamide riboside salvage pathway
def: "The chemical reactions and pathways resulting in the formation of nicotinamide adenine dinucleotide (NAD) from the nicotinamide riboside (NR)."
intersection_of: has_primary_input CHEBI:15927 ! N-ribosylnicotinamide
intersection_of: has_primary_output CHEBI:57540 ! NAD(1−)
MetaCyc: PWY3O-4106

There was some confusion in the GO terms for which compounds are Vitamin B3 derivates:
Nicotinate (NA, nicotinic acid/niacin) and nicotinamide (NAM, niacinamide) are related forms (vitamers) of vitamin B3 (see ChEBI and PMID:30559273).


  • GO:0019677 NAD catabolic process

From:

def: "The chemical reactions and pathways resulting in the breakdown of nicotinamide adenine dinucleotide (NAD), a coenzyme present in most living cells and derived from the B vitamin nicotinic acid; catabolism may be of either the oxidized form, NAD, or the reduced form, NADH." [GOC:jl, ISBN:0618254153]

To:
def:"The chemical reactions and pathways resulting in the breakdown of nicotinamide adenine dinucleotide (NAD), a coenzyme involved in many redox and catabolic reactions; catabolism may be of either the oxidized form, NAD+, or the reduced form, NADH."
intersection_of: has_primary_input CHEBI:57540 ! NAD(1−)
MetaCyc: NAD-BIOSYNTHESIS-II (the way the pathway is shown looks like catabolism, plants)

The NAD catabolic process usually feeds the NAD salvage pathway.


Terms to obsolete

        |__NADH metabolic process
        |   |__NADH oxidation
        |   |__NADH regeneration
  • These terms cover usually a 1 step reaction (NAD -> NADH) which are often part of other processes (ex. glycolysis).

  • Most of the genes annotated with the terms could be annotated to another process or their MF is enough to describe their function.

  • For "NADH metabolic process", the inclusion of NADH in the definition of NAD metabolic process makes this term redundant.

  • See also ticket NAD, NADH, NADPH processes logical definitions inconsistencies #24279

  • The only issue that remain is where to put the GO term "sulphoglycolysis" (no annotation).
    "The chemical reactions and pathways resulting in the breakdown of 6-sulfoquinovose(1-) resulting in the formation of glycerone phosphate (DHAP) and pyruvate."
    6-sulfoquinovose is sulfonic acid derivative of glucose.
    Could this term be a child of GO:0006096 glycolytic process?

@tberardini
Copy link
Contributor

Back from a few days off. I think that as long as there's no proposal to obsolete the NADP/H terms, the improvements that are suggested for NAD/H sound great and whichever ones are applicable to NADP/H would improve those terms as well.

@ukemi
Copy link
Contributor

ukemi commented Feb 5, 2025

Thanks @tberardini. I think there is a proposal to obsolete the NADPH metabolic process terms because there was an argument that the only thing NADPH does is inter-convert with NADP. @rozaru, correct me if I am wrong.

@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

I'm going to start working on the revisions to the NAD branch now.

@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

I've done all the 'easy' stuff. Here's how the tree looks now:

Image

@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

Still to do in the NAD branch:

  • Add taxon constraint 'only in eukaryotes' to GO:0034354 'de novo' NAD biosynthetic process from tryptophan
  • Obsolete 'NADH metabolic process' (26 direct EXP annotations)
  • Obsolete 'NADH oxidation' (27 direct EXP annotations)
  • Obsolete 'NADH regeneration' (9 direct EXP)
  • Consider obsoleting 'de novo' NAD biosynthetic process (1 direct EXP) as an unnecessary grouping term
    (Rossana: Probably this comes from the literature where de novo' NAD synthesis is used to group the Asp and Trp.)
  • Consider obsoleting 'GO:0034356 NAD biosynthesis via nicotinamide riboside salvage pathway' (7 direct EXP), since it's a single child of its parent term (we don't have separate terms for the other specific salvage pathways)
  • Consider obsoleting 'GO:1905012 regulation of 'de novo' NAD biosynthetic process from L-tryptophan' and it's two children (only 2 TAS annotations to the parent, none to the children), and other terms in this branch don't have regulation terms)
  • check inferred parentage of 'sulphoglycolysis', 'glycerophosphate shuttle' and 'malate-aspartate shuttle' after obsoletions above

@ukemi
Copy link
Contributor

ukemi commented Feb 6, 2025

You should remove NAD as a primary input to canonical glycolysis. Clearly something has gone wonky with that over time and glycolysis is now inferred to catabolize it. It will be interesting to see what will happen with the children of NADH regeneration when you do this. Might want to check the logical def for that.

@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

You should remove NAD as a primary input to canonical glycolysis

OK, I'll do that and see what happens....

It will be interesting to see what will happen with the children of NADH regeneration when you do this.

Note that we're proposing to obsolete 'NADH regeneration'

@ukemi
Copy link
Contributor

ukemi commented Feb 6, 2025

Ah. OK. I am getting ahead of myself, but I don't think anyone would ever think glycolysis catabolizes NAD.

sjm41 added a commit that referenced this issue Feb 6, 2025
sjm41 added a commit that referenced this issue Feb 6, 2025
@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

I changed the 'has_primary_input CHEBI:57540 ! NAD(1-)' to 'has_participant CHEBI:57540 ! NAD(1-)' on canonical glycolysis. (let me know if you think it's better just to remove it entirely).

That's fixed the spurious parentages - current tree now looks like this:

Image

@ukemi
Copy link
Contributor

ukemi commented Feb 6, 2025

It's not wrong, but probably not necessary in the LD since my guess is it won't ever be used for reasoning. The reason we had a lot of those differentia in the LDs was that we originally experimented with adding them and removing them for complete classification of the pathway wrt what else was in GO. We added and subtracted MFs and participants, ran the reasoner and then looked at the results. We tried to get the most streamlined LD that gave us full classification, but nothing incorrect. We anticipated the days when the functions would be formally defined and those could also be used.......... But I really don't think this kind of work is a priority any more.

sjm41 added a commit that referenced this issue Feb 6, 2025
Tweaked LD of canonical glycolysis again. #29050
@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

It's not wrong, but probably not necessary in the LD since my guess is it won't ever be used for reasoning.

OK, it's now gone!

@sjm41
Copy link
Contributor Author

sjm41 commented Feb 6, 2025

@pgaudet Any chance you'd be able to take care of the final NAD-related tasks in the comment above, if you agree with them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants