Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorefs.json similar to gorefs.yaml #1815

Draft
wants to merge 1 commit into
base: spatil/push-consolidated-gorefs
Choose a base branch
from

Conversation

sujaypatil96
Copy link
Contributor

Modify the goref parser so that it can generate a gorefs.json equivalent to gorefs.yaml so that it can be validated by the JSON Schema in PR #1814.

@sujaypatil96 sujaypatil96 requested a review from kltm March 17, 2022 20:40
@sujaypatil96 sujaypatil96 changed the base branch from master to spatil/push-consolidated-gorefs March 17, 2022 20:40
@kltm
Copy link
Member

kltm commented Mar 17, 2022

@sujaypatil96 You don't necessarily need to worry about PRs into your own namespace.
I'm not quite following how this json is specifically working in our workflow here, but as long as were doing:
(gorefs.yaml, source of truth) -> (checking gorefs.yaml format and fields for correctness) -> (splitting into md) -> (injecting md into go website)
Each of those should probably be a separate runnable command.
If this is for the earlier (one time) step of:
(md) -> (gorefs.yaml)
Whatever works is great :)

@kltm kltm marked this pull request as draft April 20, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants