Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #33

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Add files via upload #33

wants to merge 12 commits into from

Conversation

srz11d
Copy link
Contributor

@srz11d srz11d commented Sep 12, 2024

Updated images from the User Guide, section Admin in UI

@srz11d srz11d requested review from a team as code owners September 12, 2024 12:40
Copy link
Contributor Author

@srz11d srz11d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated images

Copy link
Contributor

@eeliane eeliane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) as I see, you've uploaded new images but haven't replaced old images on the page and haven't removed old images, will you do this? otherwise this PR looks like not finished, because only new images have been added to the folder and haven't been used anywhere

@eeliane eeliane mentioned this pull request Sep 12, 2024
@srz11d srz11d marked this pull request as draft September 13, 2024 11:25
@srz11d srz11d marked this pull request as ready for review September 26, 2024 16:06
@srz11d srz11d requested a review from MikhailAf September 30, 2024 15:20
Copy link
Contributor

@eeliane eeliane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check that old unused pictures have been not only replaced but removed from repo;
please, check that list of actions is shown correctly, currently all lists of actions look like 1 sentence;
please, check Table of content on the right side of the user guide on the "Administrator in the User Interface" page, we have lost all links/sections comparing with the develop branch;
please, check comments for changes also.

docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
*Main dashboard of the ODM. Click on your profile to access detailed information about your user capabilities*


3. As an **Admin**, you can add, edit, and delete data, users, and groups within the ODM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the instance this sentence is started with "1.", not with "3."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also: users can't be removed, they only can be deactivated; to be able to remove groups created by other users - the user should have permission "Manage groups", it's not enough to have just "Manage organization" permission

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the instance this sentence is started with "1.", not with "3."

The list is not supported due to syntax issues in code. @srz11d I suggest to review the code in IntelliJ on you local machine according to the Training provided by Mikhail Smazhevsky. Additional instructions are here https://genestack.atlassian.net/wiki/x/AoDu7

*View of the users' profile. This window contains detailed information about the groups you are part of, the capabilities (admin and curator), and the active API tokens.*

# Use Case Example: Add and update Users
As an administrator, you can add, edit, and delete users and groups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users can't be removed, they only can be deactivated; to be able to remove groups created by other users - the user should have permission "Manage groups", it's not enough to have just "Manage organization" permission

docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MikhailAf MikhailAf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review syntax, formatting, warnings and notes, and some terms.

docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
*Main dashboard of the ODM. Click on your profile to access detailed information about your user capabilities*


3. As an **Admin**, you can add, edit, and delete data, users, and groups within the ODM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the instance this sentence is started with "1.", not with "3."

The list is not supported due to syntax issues in code. @srz11d I suggest to review the code in IntelliJ on you local machine according to the Training provided by Mikhail Smazhevsky. Additional instructions are here https://genestack.atlassian.net/wiki/x/AoDu7

docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
docs/user-guide/quick-start/admin-gui.md Outdated Show resolved Hide resolved
***Hover over the permissions to view the its description**. For example, hovering over Manage groups shows that the permission allows the user: Access and manage of all groups*

Find more information about users and permissions, and their capabilities in the Defining User Permissions and Groups in the ODM section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the link to the section mentioned above? (User, Roles, Permissions)

Copy link
Contributor Author

@srz11d srz11d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax and markdowns have been amended

@srz11d srz11d marked this pull request as draft October 10, 2024 15:54
srz11d added a commit that referenced this pull request Oct 14, 2024
…n branch #33). In addition, the figures and captions have been updated.
@srz11d srz11d requested review from eeliane and MikhailAf October 23, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants