New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add calendar kind #1

Draft

Swrup wants to merge 31 commits into master from calendar-kind

Swrup commented Feb 8, 2023 •

edited by ilankri

Loading

Depends on #4.

js

96062bb

zapashcanon reviewed

View reviewed changes

dune-project Outdated Show resolved Hide resolved

Swrup force-pushed the calendar-kind branch from 14a3b91 to c456cb3 Compare

February 14, 2023 13:09

Swrup mentioned this pull request

Calendar change geneweb/geneweb#1429

Closed

Swrup force-pushed the calendar-kind branch from 3808d7c to c99364d Compare

April 28, 2023 12:26

zapashcanon reviewed

View reviewed changes

test/julian.ml Outdated Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

test/julian.ml Outdated Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

test/julian.ml Outdated Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

lib/calendars.ml Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

lib/calendars.ml Outdated Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

lib/calendars.ml Show resolved Hide resolved

zapashcanon reviewed

View reviewed changes

lib/calendars.ml Outdated Show resolved Hide resolved

Swrup force-pushed the calendar-kind branch 2 times, most recently from e949fbf to 3ab7431 Compare

May 2, 2023 13:15

zapashcanon reviewed

View reviewed changes

lib/calendars.ml Outdated Show resolved Hide resolved

Swrup force-pushed the calendar-kind branch from 3ab7431 to fa0b109 Compare

May 2, 2023 14:52

Swrup force-pushed the calendar-kind branch from ea0dbeb to fa0b109 Compare

May 10, 2023 07:19

ilankri marked this pull request as draft

December 20, 2024 13:25

ilankri self-assigned this

ilankri and others added 11 commits

December 23, 2024 15:41


          Build: Fix the JavaScript generation via Dune

3eeed32

See ocaml/dune#3815.


          Cleanup: Remove some commented code

d66dbf2


          Cleanup: Get rid of some top-level opens

d4711bc


          Cleanup: Fix typos in some record patterns

c3e4ed1


          Cleanup: Use () for a unit value

18b761d


          add license; readme

086b82c


          generate opam file

82e7f7c


          rename

db314c5


          add .ocamlformat

9f11898

fmt

dd35f7b


          add calendar kind

1c0d311

swrup and others added 14 commits

December 23, 2024 16:57


          change make to result

440bb32


          use gadt

6ca9e76


          clean up; add comments

16592a9


          remove partial date conversion

1a9e444


          fix duplicate depends on dune

b6535b1


          better error message

806ea07


          remove unescessary conversion

7e20517


          better checks in make

aa07cf2


          test for gregorian too

d1438c6


          rename

272e800


          small clean up

e22c337


          fix issue with french complementary month

4a6d2f3


          .gitignore: Ignore the directories used for opam local switches

b29f171


          Cleanup: Reformat some code using ocamlformat

62bd5e7

ilankri force-pushed the calendar-kind branch from d1a36ad to b181eda Compare

December 23, 2024 16:08

ilankri force-pushed the calendar-kind branch 4 times, most recently from 9790b1b to ea7c6bd Compare

January 3, 2025 10:07


          lib: Move some code

b3501d7

ilankri force-pushed the calendar-kind branch from ea7c6bd to 71c1d73 Compare

January 3, 2025 11:44

ilankri added 3 commits

January 3, 2025 12:44


          lib: Change the way the type Calendars.date is defined

f1424fb


          lib: Use a rich error type in the return type of Calendars.make

5dba16c


          js: Adapt the glue code for the JavaScript library

78c9b8e

ilankri force-pushed the calendar-kind branch from 71c1d73 to 78c9b8e Compare

January 3, 2025 11:45

ilankri added a commit to ilankri/geneweb that referenced this pull request


          util: Adapt the code to geneweb/calendars#1

d13d491

ilankri mentioned this pull request

ged2gwb: Prevent importing invalid dates geneweb/geneweb#2018

Draft

ilankri added a commit to ilankri/geneweb that referenced this pull request


          util: Adapt the code to geneweb/calendars#1

411220c

ilankri requested a review from canonici

January 3, 2025 17:05

ilankri added a commit to ilankri/geneweb that referenced this pull request


          util: Adapt the code to geneweb/calendars#1

d2db9b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet