keep using AddHeader for .NET (Core) as it ensures a safe configuration.

It sets the header if !response.HasStarted.
genexuslabs · Jul 6, 2023 · ac327a0 · ac327a0
1 parent 9511570
commit ac327a0
Showing 1 changed file with 36 additions and 30 deletions.
diff --git a/dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs b/dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs
@@ -47,7 +47,7 @@ namespace GeneXus.Application
 	using System.Threading;
 	using System.Security.Claims;
 	using System.Security;
-
+	
 	public interface IGxContext
 	{
 		void disableOutput();
@@ -2429,37 +2429,39 @@ public byte SetHeader(string name, string value)
 
 		private void SetCustomHttpHeader(string name, string value)
 		{
-#if !NETCORE
-			switch (name.ToUpper())
+			try
 			{
-				case "CACHE-CONTROL":
-					var Cache = _HttpContext.Response.Cache;
-					string[] values = value.Split(',');
-					foreach (string v in values)
-					{
-						switch (v.Trim().ToUpper())
+#if !NETCORE
+				switch (name.ToUpper())
+				{
+					case "CACHE-CONTROL":
+						var Cache = _HttpContext.Response.Cache;
+						string[] values = value.Split(',');
+						foreach (string v in values)
 						{
-							case "PUBLIC":
-								Cache.SetCacheability(HttpCacheability.Public);
-								break;
-							case "PRIVATE":
-								Cache.SetCacheability(HttpCacheability.Private);
-								break;
-							case "NO-CACHE":
-								Cache.SetCacheability(HttpCacheability.NoCache);
-								break;
-							case "NO-STORE":
-								Cache.AppendCacheExtension("no-store, must-revalidate");
-								break;
-							default:
-								break;
+							switch (v.Trim().ToUpper())
+							{
+								case "PUBLIC":
+									Cache.SetCacheability(HttpCacheability.Public);
+									break;
+								case "PRIVATE":
+									Cache.SetCacheability(HttpCacheability.Private);
+									break;
+								case "NO-CACHE":
+									Cache.SetCacheability(HttpCacheability.NoCache);
+									break;
+								case "NO-STORE":
+									Cache.AppendCacheExtension("no-store, must-revalidate");
+									break;
+								default:
+									break;
+							}
 						}
-					}
-					break;
-				default:
-					_HttpContext.Response.Headers[name]=value;
-					break;
-			}
+						break;
+					default:
+						_HttpContext.Response.Headers[name] = value;
+						break;
+				}
 #else
 			switch (name.ToUpper())
 			{
@@ -2478,10 +2480,14 @@ private void SetCustomHttpHeader(string name, string value)
 					}
 					break;
 				default:
-					_HttpContext.Response.Headers[name] = value;
+					_HttpContext.Response.AddHeader(name, value);
 					break;
 			}
 #endif
+			}catch (Exception ex)
+			{
+				GXLogging.Error(log, ex, "Error adding header ", name, value);
+			}
 		}
 
 		public string GetHeader(string name)