Http dispatcher refactoring #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiamurialdo
approved these changes
Jul 16, 2021
claudiamurialdo
added a commit
that referenced
this pull request
May 25, 2022
Fixes the error: System.ObjectDisposedException: IFeatureCollection has been disposed. Object name: 'Collection'. at Microsoft.AspNetCore.Http.Features.FeatureReferences`1.ThrowContextDisposed() at Microsoft.AspNetCore.Http.DefaultHttpContext.get_Session() According to: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AspNetCoreGuidance.md#do-not-store-ihttpcontextaccessorhttpcontext-in-a-field
claudiamurialdo
added a commit
that referenced
this pull request
May 31, 2022
…#596) * Restore GxHttpContextAccesor lost at #393 Http dispatcher refactoring Fixes the error: System.ObjectDisposedException: IFeatureCollection has been disposed. Object name: 'Collection'. at Microsoft.AspNetCore.Http.Features.FeatureReferences`1.ThrowContextDisposed() at Microsoft.AspNetCore.Http.DefaultHttpContext.get_Session() According to: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AspNetCoreGuidance.md#do-not-store-ihttpcontextaccessorhttpcontext-in-a-field * Remove unneeded Console.Writeline. * Reduce max number of concurrent threads on test. Concurrency is tested anyway and test output gets smaller. * Complete code for testing the error: System.ObjectDisposedException: IFeatureCollection has been disposed. Object name: 'Collection'. at Microsoft.AspNetCore.Http.Features.FeatureReferences`1.ThrowContextDisposed() at Microsoft.AspNetCore.Http.Features.FeatureReferences`1.ContextDisposed() * Fix build error on GXMultiCall.webExecute method. * Add output message for unit test on dfrgtxt to diagnose failing tests. * Specify full path for tests with FileIO to avoid conflict with aspnetcore tests since GxContext.StaticPhysicalPath() returns a different value depending on the context (web or batch). * Set BaseDir for FullTextSearchTests. * Override Write method for GxHttpAzureResponse because WriteAsync is not supported. * Restore synchronous writing on httpreponse because GxHttpAzureResponse does not support it. For writing json should be used WriteAsJsonAsync which is supported by GxHttpAzureResponse. Soon it will be analyzed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in net core Http dispatcher to be able to support Azure Http functions.
Issue:90167