Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for submitted threads to end before terminating a command line procedure - new implementation #580

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

claudiamurialdo
Copy link
Collaborator

This PR re-implements #446 in a better way that takes into account only the threads started by a Submit call type. It does not wait for other threads to finish (like the ones started by aspnet thread pool).
Issue:24006

…y the threads started by a Submit call type. It does not wait for other threads to finish (like the ones started by aspnet thread pool).
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 31, 2022 15:46 Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 31, 2022 20:27 Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 31, 2022 22:24 Inactive
iroqueta
iroqueta previously approved these changes Mar 31, 2022
@claudiamurialdo claudiamurialdo changed the title Second version: Wait for submitted threads to end before terminating a command line procedure Wait for submitted threads to end before terminating a command line procedure - new implementation Apr 1, 2022
Take into account limitation of WaitHandle.WaitAll and 64 threads.
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit c55408d
  • dotnet/src/dotnetframework/GxClasses/Core/GXUtilsCommon.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Apr 26, 2022
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Apr 26, 2022
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 26, 2022 13:01 Inactive
@claudiamurialdo claudiamurialdo merged commit 521d23a into master Apr 26, 2022
@claudiamurialdo claudiamurialdo deleted the submit-thread-wait branch April 26, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants