AWS S3: Use mulitpart post to upload large files from Streams. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta success |
Cherry pick to beta success |
ggallotti
changed the title
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #435 , we started using MemoryStream for Stream Uploads because we don't know the object size of the network stream.
AWS S3 High Level API does not support uploads of Streams with undefined length.
The LowLevel S3 API does support upload of streams with undefined length. We start using this mechanism.
Code was inspired from:
https://github.com/mlhpdx/s3-upload-stream