Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Bus API implementation #629

Merged
merged 15 commits into from
Nov 15, 2022
Merged

Service Bus API implementation #629

merged 15 commits into from
Nov 15, 2022

Conversation

sjuarezgx
Copy link
Contributor

@sjuarezgx sjuarezgx had a problem deploying to external-storage-tests July 11, 2022 00:51 Failure
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 2 conflicted files in commit f6acb82
  • dotnet/DotNetStandardClasses.sln
  • dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jul 11, 2022
@sjuarezgx sjuarezgx requested a review from ggallotti July 11, 2022 00:53
@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests July 11, 2022 01:03 Inactive
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jul 11, 2022
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests September 15, 2022 12:07 Inactive
@sjuarezgx sjuarezgx had a problem deploying to external-storage-tests September 25, 2022 22:09 Failure
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx had a problem deploying to external-storage-tests September 25, 2022 22:16 Failure
@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests September 25, 2022 22:50 Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests September 28, 2022 21:22 Inactive
@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests September 28, 2022 21:28 Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

ggallotti
ggallotti reviewed Oct 31, 2022
View reviewed changes
dotnet/src/dotnetcore/Providers/Messaging/GXMessageBroker/MessageBrokerProvider.cs Outdated
MessageQueue messageQueue = new MessageQueue();
if (string.IsNullOrEmpty(providerTypeName))
{
GXUtil.ErrorToMessages("GXMessageBroker1000", "Message Broker provider cannot be empty", errorMessages);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"'GXMessageBroker1000". Why the "1000"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You suggest starting with code 1? or what do you suggest? thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the numbers.

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests November 14, 2022 15:02 Inactive
@sjuarezgx sjuarezgx requested a review from ggallotti November 14, 2022 15:03
@ggallotti
Copy link
Member

I've added @claudiamurialdo to help for review this PR.

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests November 15, 2022 01:25 Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests November 15, 2022 11:33 Inactive
@sjuarezgx sjuarezgx requested a review from AlejandroP November 15, 2022 21:28
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests November 15, 2022 21:46 Inactive
@sjuarezgx sjuarezgx merged commit 3a24a58 into master Nov 15, 2022
@sjuarezgx sjuarezgx deleted the ServiceBusAPI branch November 15, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggallotti ggallotti ggallotti approved these changes

@claudiamurialdo claudiamurialdo Awaiting requested review from claudiamurialdo

@AlejandroP AlejandroP Awaiting requested review from AlejandroP

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjuarezgx @genexusbot @ggallotti