Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for chunked httpclient and httpresponse. #823

Merged
merged 16 commits into from
Jun 30, 2023
Merged

Add support for chunked httpclient and httpresponse. #823

merged 16 commits into from
Jun 30, 2023

Conversation

claudiamurialdo
Copy link
Collaborator

@claudiamurialdo claudiamurialdo commented Jun 1, 2023 •
edited
Loading

Issue:103034
For .NET framework move SendHeaders() to the begining of the GxWebProcedure to support chunked responses at http procedures.

@claudiamurialdo claudiamurialdo requested a review from ggallotti June 1, 2023 18:54
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 1, 2023 18:54 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo changed the title Add support for chunked httpclient and chuncked httpresponse. Add support for chunked httpclient and httpresponse. Jun 1, 2023
@claudiamurialdo
Do not append headers for X-GXOBJECT and X-UA-Compatible.
780baa1 
X-GXOBJECT is set twice when called from SendHeaders and ValidateSpaRequest from webExecute.
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 7, 2023 01:41 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 7, 2023 01:47 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 15, 2023 21:48 — with GitHub Actions Inactive
@claudiamurialdo
Delay adding the header X-SPA-MP until the MasterPageObj is instantia…
8a9872d 
…ted.

Since sendSpaHeaders is called at the start of execution, the MasterPageObj is null at this moment.
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 16, 2023 15:12 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit ab2cc19
  • dotnet/src/dotnetframework/GxClasses/Model/GXWebProcedure.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jun 16, 2023
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jun 16, 2023
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 211451d
  • dotnet/src/dotnetframework/GxClasses/Model/GXWebProcedure.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jun 20, 2023
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jun 20, 2023
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 21, 2023 17:53 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 21, 2023 18:10 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 26, 2023 14:49 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo
Access SessionId at the beginning of Streamed https procs o to avoid …
b96630a 
…HttpException: Session state has created a session id, but cannot save it because the response was already flushed by the application.
@claudiamurialdo claudiamurialdo had a problem deploying to external-storage-tests June 28, 2023 18:29 — with GitHub Actions Failure
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 28, 2023 19:52 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo merged commit 4fbfb00 into master Jun 30, 2023
@claudiamurialdo claudiamurialdo deleted the http-chunked branch June 30, 2023 16:15
@claudiamurialdo claudiamurialdo mentioned this pull request Jul 5, 2023
Merged
ggallotti added a commit that referenced this pull request Jul 11, 2023
@ggallotti
Revert "Add support for chunked httpclient and httpresponse. (#823)"
8b5868f 
This reverts commit 4fbfb00.
@ggallotti ggallotti mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggallotti ggallotti ggallotti left review comments

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claudiamurialdo @genexusbot @ggallotti