Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paging statements with SqlServer 2005 when the statement uses aliases #833

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Fix paging statements with SqlServer 2005 when the statement uses aliases #833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c46104
Fix paging statements with SqlServer 2005 when the statement uses ali…
gusbro Jun 21, 2023
0d1dcf6
Update regex to only match whole select attributes and skip CAST sube…
gusbro Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions dotnet/src/dotnetframework/GxClasses/Core/GXUtilsCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5467,6 +5467,25 @@ public static string PagingSelect(string select)
pagingSelect = pagingSelect.Substring(9);

pagingSelect = Regex.Replace(pagingSelect, @"T\d+\.", "GX_ICTE.");
try
{
IDictionary<string, string> maps = new Dictionary<string, string>();
foreach (Match match in Regex.Matches(pagingSelect, @"GX_ICTE\.(\[\w+]) AS \b(\w+)\b(?=,|$)", RegexOptions.Compiled | RegexOptions.CultureInvariant))
{
if (match.Groups.Count == 3)
{
maps[match.Groups[0].Value] = $"GX_ICTE.[{match.Groups[2].Value}]";
maps[match.Groups[1].Value] = $"[{match.Groups[2].Value}]";
}
}
foreach (KeyValuePair<string, string> map in maps)
pagingSelect = pagingSelect.Replace(map.Key, map.Value);
}
catch (RegexMatchTimeoutException ex)
{
GXLogging.Warn(log, ex, "Timeout parsing paging select");
}

return pagingSelect;
}

Expand Down