Azure Event Grid API implementation #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta failed, 1 conflicted file in commit 3b8aa35
|
Manual cherry pick to beta success |
Add AD Authentication.
Cherry pick to beta success |
sjuarezgx
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
ggallotti
reviewed
Jul 25, 2023
dotnet/src/dotnetcore/Providers/Messaging/GXAzureEventGrid/AzureEventGrid.cs
Show resolved
Hide resolved
ggallotti
reviewed
Jul 25, 2023
| success = successConnect; | ||
| return evtRouterProvider; | ||
| } | ||
| /*public EventRouterProviderBase Connect(string endpoint, out GXBaseCollection<SdtMessages_Message> errorMessages, out bool success) |
There was a problem hiding this comment.
Can we remove this commented code?
ggallotti
reviewed
Jul 25, 2023
|
|
||
| /*if (string.IsNullOrEmpty(_accessKey)) | ||
|
|
||
| //Try using Active Directory authentication |
There was a problem hiding this comment.
Can we remove this commented code?
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
ggallotti
reviewed
Jul 25, 2023
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw ex; |
There was a problem hiding this comment.
The try-catch block is not really needed here.
ggallotti
reviewed
Jul 25, 2023
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw ex; |
There was a problem hiding this comment.
The try-catch block is not really needed here.
ggallotti
reviewed
Jul 25, 2023
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw ex; |
There was a problem hiding this comment.
The try-catch block is not really needed here.
ggallotti
reviewed
Jul 25, 2023
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw ex; |
There was a problem hiding this comment.
The try-catch block is not really needed here.
There was a problem hiding this comment.
All try catch blocks removed. The test is automated in fullgx.
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
ggallotti
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:103791