Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support on python3.3 #104

Merged
merged 2 commits into from
May 17, 2019
Merged

Drop support on python3.3 #104

merged 2 commits into from
May 17, 2019

Conversation

ryvasquez
Copy link
Contributor

Description

@ryvasquez ryvasquez marked this pull request as ready for review May 17, 2019 04:56
@ryvasquez
Copy link
Contributor Author

ryvasquez commented May 17, 2019 •
edited
Loading

The travis error will be fixed in the different PR

gengo/gengo.py:225:18: W605 invalid escape sequence '\{'
gengo/gengo.py:225:20: W605 invalid escape sequence '\{'
gengo/gengo.py:225:39: W605 invalid escape sequence '\}'
gengo/gengo.py:225:41: W605 invalid escape sequence '\}'

narusemotoki
narusemotoki previously approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@narusemotoki narusemotoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephniel
josephniel previously approved these changes May 17, 2019
View reviewed changes
jeanklingler
jeanklingler previously approved these changes May 17, 2019
View reviewed changes
Copy link

@jeanklingler jeanklingler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

josephniel
josephniel approved these changes May 17, 2019
View reviewed changes
Copy link

@josephniel josephniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@ryvasquez ryvasquez merged commit 8da92b8 into master May 17, 2019
@ryvasquez ryvasquez deleted the drop-python3.3-support branch May 17, 2019 06:30
@ryvasquez ryvasquez mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephniel josephniel josephniel approved these changes

@narusemotoki narusemotoki narusemotoki left review comments

@jeanklingler jeanklingler jeanklingler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryvasquez @narusemotoki @josephniel @jeanklingler