Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from Hanson Robotics #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

linas
Copy link

@linas linas commented Nov 11, 2014

No description provided.

@linas
Copy link
Author

linas commented Nov 11, 2014

err, don't merge yet ... there are some problem here, I will fix them shortly.

@linas
Copy link
Author

linas commented Nov 11, 2014

OK, I fixed the few obvious packaging bugs. This is now ready to be pulled. Vytas made several changes I am not clear about:
-- using wav instead of/in addition to mp3
-- something to do with the jaw
-- publish of jaw movement for the dmitri robot

I don't know if/how any of these changes might break compatiblity

@linas
Copy link
Author

linas commented Nov 11, 2014

@@ -14,17 +15,18 @@
class ITFTalker(Thread):
NODE_NAME = 'itf_talker'
pub = rospy.Publisher('itf_next_sentence', String, queue_size=1)
pub_speech_strength = rospy.Publisher('speech_strength', Float32, queue_size=1)
pub_speech_strength = rospy.Publisher('/dmitry/jaw_controller/command', Float64, queue_size=1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed back to how it was; its bad to hard code the topic name to produce data for a particular system.

The dmitry jaw controller should instead subscribe to the topic speech_strength.

@linas
Copy link
Author

linas commented Nov 12, 2014

Update per comments. There's not much that is interesting that is left ...

@linas
Copy link
Author

linas commented Nov 17, 2014

Do the mp3->wav conversions look reasonable? If not, let me know, else please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants