-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from Hanson Robotics #1
base: master
Are you sure you want to change the base?
Conversation
err, don't merge yet ... there are some problem here, I will fix them shortly. |
OK, I fixed the few obvious packaging bugs. This is now ready to be pulled. Vytas made several changes I am not clear about: I don't know if/how any of these changes might break compatiblity |
@@ -14,17 +15,18 @@ | |||
class ITFTalker(Thread): | |||
NODE_NAME = 'itf_talker' | |||
pub = rospy.Publisher('itf_next_sentence', String, queue_size=1) | |||
pub_speech_strength = rospy.Publisher('speech_strength', Float32, queue_size=1) | |||
pub_speech_strength = rospy.Publisher('/dmitry/jaw_controller/command', Float64, queue_size=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be changed back to how it was; its bad to hard code the topic name to produce data for a particular system.
The dmitry jaw controller should instead subscribe to the topic speech_strength.
Update per comments. There's not much that is interesting that is left ... |
Do the mp3->wav conversions look reasonable? If not, let me know, else please merge. |
No description provided.