-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle common prefixes in variant alleles #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏!
Could you elaborate what this tries to solve? I believe genome nexus annotation pipeline does this prefix normalization as well that's a common artifacts of VCF->MAF conversion. Not saying it shouldn't be in this script (prolly makes sense to do normalization before annotation). Just wondering if the goal of this script is basically to do all the normalization pre running annotation in the annotation pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ao508 sounds good! I'm just a bit worried about not capturing these corner cases as tests in some way. Can be done later, but prolly good to file some ticket in that case
Like currently as a reviewer it's really hard to verify whether this is working, because there is no example data in the repo
EDIT: filed a separate ticket for testing: #40
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
6f71e4b
to
781b34e
Compare
Nice this solve my issue #30 as well - Thank you! |
Signed-off-by: Angelica Ochoa 15623749+ao508@users.noreply.github.com