Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle common prefixes in variant alleles #39

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

ao508
Copy link
Contributor

@ao508 ao508 commented Mar 25, 2021

Signed-off-by: Angelica Ochoa 15623749+ao508@users.noreply.github.com

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏!

Could you elaborate what this tries to solve? I believe genome nexus annotation pipeline does this prefix normalization as well that's a common artifacts of VCF->MAF conversion. Not saying it shouldn't be in this script (prolly makes sense to do normalization before annotation). Just wondering if the goal of this script is basically to do all the normalization pre running annotation in the annotation pipeline?

@ao508
Copy link
Contributor Author

ao508 commented Mar 25, 2021

Just based on the variants Tom had shared in issue #34 I noticed there were common prefixes that the standardization script didnt resolve so the script handles that now. I'm not sure if it will resolve all of the issues reported in #34 but it will at least address some

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ao508 sounds good! I'm just a bit worried about not capturing these corner cases as tests in some way. Can be done later, but prolly good to file some ticket in that case

Like currently as a reviewer it's really hard to verify whether this is working, because there is no example data in the repo

EDIT: filed a separate ticket for testing: #40

@ao508 ao508 removed the request for review from averyniceday March 25, 2021 18:35
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
@ao508 ao508 force-pushed the resolve-incorrect-alleles branch from 6f71e4b to 781b34e Compare March 26, 2021 15:06
@inodb
Copy link
Member

inodb commented Mar 26, 2021

Nice this solve my issue #30 as well - Thank you!

@inodb inodb merged commit 916df0f into genome-nexus:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genome Nexus: 41 variants that have incorrectly annotated ref/alt.
2 participants